mirror of
https://github.com/nodejs/node.git
synced 2025-05-11 03:05:55 +00:00
30892c8fb4
Test test-require-deps-deprecation.js was failing when user already had node installed with acorn in require.resolve range. Modified test to acknowledge the possibility and throw only if acorn is found in the deps directory. PR-URL: https://github.com/nodejs/node/pull/17848 Fixes: https://github.com/nodejs/node/issues/17148 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
56 lines
1.5 KiB
JavaScript
56 lines
1.5 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
// The v8 modules when imported leak globals. Disable global check.
|
|
common.globalCheck = false;
|
|
|
|
const deprecatedModules = [
|
|
'node-inspect/lib/_inspect',
|
|
'node-inspect/lib/internal/inspect_client',
|
|
'node-inspect/lib/internal/inspect_repl',
|
|
'v8/tools/SourceMap',
|
|
'v8/tools/codemap',
|
|
'v8/tools/consarray',
|
|
'v8/tools/csvparser',
|
|
'v8/tools/logreader',
|
|
'v8/tools/profile',
|
|
'v8/tools/profile_view',
|
|
'v8/tools/splaytree',
|
|
'v8/tools/tickprocessor',
|
|
'v8/tools/tickprocessor-driver'
|
|
];
|
|
|
|
// Newly added deps that do not have a deprecation wrapper around it would
|
|
// throw an error, but no warning would be emitted.
|
|
const deps = [
|
|
'acorn/dist/acorn',
|
|
'acorn/dist/walk'
|
|
];
|
|
|
|
common.expectWarning('DeprecationWarning', deprecatedModules.map((m) => {
|
|
return `Requiring Node.js-bundled '${m}' module is deprecated. ` +
|
|
'Please install the necessary module locally.';
|
|
}));
|
|
|
|
for (const m of deprecatedModules) {
|
|
try {
|
|
require(m);
|
|
} catch (err) {}
|
|
}
|
|
|
|
// Instead of checking require, check that resolve isn't pointing toward a
|
|
// built-in module, as user might already have node installed with acorn in
|
|
// require.resolve range.
|
|
// Ref: https://github.com/nodejs/node/issues/17148
|
|
for (const m of deps) {
|
|
let path;
|
|
try {
|
|
path = require.resolve(m);
|
|
} catch (err) {
|
|
assert.ok(err.toString().startsWith('Error: Cannot find module '));
|
|
continue;
|
|
}
|
|
assert.notStrictEqual(path, m);
|
|
}
|