mirror of
https://github.com/nodejs/node.git
synced 2025-05-11 22:07:57 +00:00

PR-URL: https://github.com/nodejs/node/pull/17406 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> This is a significant cleanup and refactoring of the cleanup/close/destroy logic for Http2Stream and Http2Session. There are significant changes here in the timing and ordering of cleanup logic, JS apis. and various related necessary edits.
57 lines
1.4 KiB
JavaScript
57 lines
1.4 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const http2 = require('http2');
|
|
|
|
// Check that pushStream handles being passed wrong arguments
|
|
// in the expected manner
|
|
|
|
const server = http2.createServer();
|
|
server.on('stream', common.mustCall((stream, headers) => {
|
|
const port = server.address().port;
|
|
|
|
// Must receive a callback (function)
|
|
common.expectsError(
|
|
() => stream.pushStream({
|
|
':scheme': 'http',
|
|
':path': '/foobar',
|
|
':authority': `localhost:${port}`,
|
|
}, {}, 'callback'),
|
|
{
|
|
code: 'ERR_INVALID_CALLBACK',
|
|
message: 'Callback must be a function'
|
|
}
|
|
);
|
|
|
|
// Must validate headers
|
|
common.expectsError(
|
|
() => stream.pushStream({ 'connection': 'test' }, {}, () => {}),
|
|
{
|
|
code: 'ERR_HTTP2_INVALID_CONNECTION_HEADERS',
|
|
message: 'HTTP/1 Connection specific headers are forbidden: "connection"'
|
|
}
|
|
);
|
|
|
|
stream.end('test');
|
|
}));
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const port = server.address().port;
|
|
const headers = { ':path': '/' };
|
|
const client = http2.connect(`http://localhost:${port}`);
|
|
const req = client.request(headers);
|
|
req.setEncoding('utf8');
|
|
|
|
let data = '';
|
|
req.on('data', common.mustCall((d) => data += d));
|
|
req.on('end', common.mustCall(() => {
|
|
assert.strictEqual(data, 'test');
|
|
server.close();
|
|
client.close();
|
|
}));
|
|
req.end();
|
|
}));
|