node/test/parallel/test-http-client-reject-unexpected-agent.js
Ruben Bridgewater caee112e52
test: remove assert.doesNotThrow()
There is actually no reason to use `assert.doesNotThrow()` in the
tests. If a test throws, just let the error bubble up right away
instead of first catching it and then rethrowing it.

PR-URL: https://github.com/nodejs/node/pull/18669
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2018-02-16 16:53:47 +01:00

69 lines
1.4 KiB
JavaScript

'use strict';
const common = require('../common');
const assert = require('assert');
const http = require('http');
const baseOptions = {
method: 'GET',
port: undefined,
host: common.localhostIPv4,
};
const failingAgentOptions = [
true,
'agent',
{},
1,
() => null,
Symbol(),
];
const acceptableAgentOptions = [
false,
undefined,
null,
new http.Agent(),
];
const server = http.createServer((req, res) => {
res.end('hello');
});
let numberOfResponses = 0;
function createRequest(agent) {
const options = Object.assign(baseOptions, { agent });
const request = http.request(options);
request.end();
request.on('response', common.mustCall(() => {
numberOfResponses++;
if (numberOfResponses === acceptableAgentOptions.length) {
server.close();
}
}));
}
server.listen(0, baseOptions.host, common.mustCall(function() {
baseOptions.port = this.address().port;
failingAgentOptions.forEach((agent) => {
common.expectsError(
() => createRequest(agent),
{
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "Agent option" argument must be one of type ' +
'Agent-like Object, undefined, or false'
}
);
});
acceptableAgentOptions.forEach((agent) => {
createRequest(agent);
});
}));
process.on('exit', () => {
assert.strictEqual(numberOfResponses, acceptableAgentOptions.length);
});