mirror of
https://github.com/nodejs/node.git
synced 2025-05-13 02:59:02 +00:00
caee112e52
There is actually no reason to use `assert.doesNotThrow()` in the tests. If a test throws, just let the error bubble up right away instead of first catching it and then rethrowing it. PR-URL: https://github.com/nodejs/node/pull/18669 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
100 lines
2.1 KiB
JavaScript
100 lines
2.1 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const cares = process.binding('cares_wrap');
|
|
const dns = require('dns');
|
|
|
|
// Stub `getaddrinfo` to *always* error.
|
|
cares.getaddrinfo = () => process.binding('uv').UV_ENOENT;
|
|
|
|
common.expectsError(() => {
|
|
dns.lookup(1, {});
|
|
}, {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: /^The "hostname" argument must be one of type string or falsy/
|
|
});
|
|
|
|
common.expectsError(() => {
|
|
dns.lookup(false, 'cb');
|
|
}, {
|
|
code: 'ERR_INVALID_CALLBACK',
|
|
type: TypeError
|
|
});
|
|
|
|
common.expectsError(() => {
|
|
dns.lookup(false, 'options', 'cb');
|
|
}, {
|
|
code: 'ERR_INVALID_CALLBACK',
|
|
type: TypeError
|
|
});
|
|
|
|
common.expectsError(() => {
|
|
dns.lookup(false, {
|
|
hints: 100,
|
|
family: 0,
|
|
all: false
|
|
}, common.mustNotCall());
|
|
}, {
|
|
code: 'ERR_INVALID_OPT_VALUE',
|
|
type: TypeError,
|
|
message: 'The value "100" is invalid for option "hints"'
|
|
});
|
|
|
|
common.expectsError(() => {
|
|
dns.lookup(false, {
|
|
hints: 0,
|
|
family: 20,
|
|
all: false
|
|
}, common.mustNotCall());
|
|
}, {
|
|
code: 'ERR_INVALID_OPT_VALUE',
|
|
type: TypeError,
|
|
message: 'The value "20" is invalid for option "family"'
|
|
});
|
|
|
|
dns.lookup(false, {
|
|
hints: 0,
|
|
family: 0,
|
|
all: true
|
|
}, common.mustCall((error, result, addressType) => {
|
|
assert.ifError(error);
|
|
assert.deepStrictEqual(result, []);
|
|
assert.strictEqual(addressType, undefined);
|
|
}));
|
|
|
|
dns.lookup('127.0.0.1', {
|
|
hints: 0,
|
|
family: 4,
|
|
all: true
|
|
}, common.mustCall((error, result, addressType) => {
|
|
assert.ifError(error);
|
|
assert.deepStrictEqual(result, [{
|
|
address: '127.0.0.1',
|
|
family: 4
|
|
}]);
|
|
assert.strictEqual(addressType, undefined);
|
|
}));
|
|
|
|
dns.lookup('127.0.0.1', {
|
|
hints: 0,
|
|
family: 4,
|
|
all: false
|
|
}, common.mustCall((error, result, addressType) => {
|
|
assert.ifError(error);
|
|
assert.deepStrictEqual(result, '127.0.0.1');
|
|
assert.strictEqual(addressType, 4);
|
|
}));
|
|
|
|
let tickValue = 0;
|
|
|
|
dns.lookup('example.com', common.mustCall((error, result, addressType) => {
|
|
assert(error);
|
|
assert.strictEqual(tickValue, 1);
|
|
assert.strictEqual(error.code, 'ENOENT');
|
|
}));
|
|
|
|
// Make sure that the error callback is called
|
|
// on next tick.
|
|
tickValue = 1;
|