mirror of
https://github.com/nodejs/node.git
synced 2025-05-08 21:49:48 +00:00
42dbaed460
This introduces TLS1.3 support and makes it the default max protocol,
but also supports CLI/NODE_OPTIONS switches to disable it if necessary.
TLS1.3 is a major update to the TLS protocol, with many security
enhancements. It should be preferred over TLS1.2 whenever possible.
TLS1.3 is different enough that even though the OpenSSL APIs are
technically API/ABI compatible, that when TLS1.3 is negotiated, the
timing of protocol records and of callbacks broke assumptions hard-coded
into the 'tls' module.
This change introduces no API incompatibilities when TLS1.2 is
negotiated. It is the intention that it be backported to current and LTS
release lines with the default maximum TLS protocol reset to 'TLSv1.2'.
This will allow users of those lines to explicitly enable TLS1.3 if they
want.
API incompatibilities between TLS1.2 and TLS1.3 are:
- Renegotiation is not supported by TLS1.3 protocol, attempts to call
`.renegotiate()` will always fail.
- Compiling against a system OpenSSL lower than 1.1.1 is no longer
supported (OpenSSL-1.1.0 used to be supported with configure flags).
- Variations of `conn.write('data'); conn.destroy()` have undefined
behaviour according to the streams API. They may or may not send the
'data', and may or may not cause a ERR_STREAM_DESTROYED error to be
emitted. This has always been true, but conditions under which the write
suceeds is slightly but observably different when TLS1.3 is negotiated
vs when TLS1.2 or below is negotiated.
- If TLS1.3 is negotiated, and a server calls `conn.end()` in its
'secureConnection' listener without any data being written, the client
will not receive session tickets (no 'session' events will be emitted,
and `conn.getSession()` will never return a resumable session).
- The return value of `conn.getSession()` API may not return a resumable
session if called right after the handshake. The effect will be that
clients using the legacy `getSession()` API will resume sessions if
TLS1.2 is negotiated, but will do full handshakes if TLS1.3 is
negotiated. See https://github.com/nodejs/node/pull/25831 for more
information.
PR-URL: https://github.com/nodejs/node/pull/26209
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
77 lines
2.1 KiB
JavaScript
77 lines
2.1 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const fixtures = require('../common/fixtures');
|
|
const SSL_OP_NO_TICKET = require('crypto').constants.SSL_OP_NO_TICKET;
|
|
const tls = require('tls');
|
|
|
|
// Check that TLS1.2 session resumption callbacks don't explode when made after
|
|
// the tls socket is destroyed. Disable TLS ticket support to force the legacy
|
|
// session resumption mechanism to be used.
|
|
|
|
// TLS1.2 is the last protocol version to support TLS sessions, after that the
|
|
// new and resume session events will never be emitted on the server.
|
|
|
|
const options = {
|
|
secureOptions: SSL_OP_NO_TICKET,
|
|
key: fixtures.readSync('test_key.pem'),
|
|
cert: fixtures.readSync('test_cert.pem')
|
|
};
|
|
|
|
const server = tls.createServer(options, common.mustCall());
|
|
|
|
let sessionCb = null;
|
|
let client = null;
|
|
|
|
server.on('newSession', common.mustCall((key, session, done) => {
|
|
done();
|
|
}));
|
|
|
|
server.on('resumeSession', common.mustCall((id, cb) => {
|
|
sessionCb = cb;
|
|
// Destroy the client and then call the session cb, to check that the cb
|
|
// doesn't explode when called after the handle has been destroyed.
|
|
next();
|
|
}));
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const clientOpts = {
|
|
// Don't send a TLS1.3/1.2 ClientHello, they contain a fake session_id,
|
|
// which triggers a 'resumeSession' event for client1. TLS1.2 ClientHello
|
|
// won't have a session_id until client2, which will have a valid session.
|
|
maxVersion: 'TLSv1.2',
|
|
port: server.address().port,
|
|
rejectUnauthorized: false,
|
|
session: false
|
|
};
|
|
|
|
const s1 = tls.connect(clientOpts, common.mustCall(() => {
|
|
clientOpts.session = s1.getSession();
|
|
console.log('1st secure');
|
|
|
|
s1.destroy();
|
|
const s2 = tls.connect(clientOpts, (s) => {
|
|
console.log('2nd secure');
|
|
|
|
s2.destroy();
|
|
}).on('connect', common.mustCall(() => {
|
|
console.log('2nd connected');
|
|
client = s2;
|
|
|
|
next();
|
|
}));
|
|
}));
|
|
}));
|
|
|
|
function next() {
|
|
if (!client || !sessionCb)
|
|
return;
|
|
|
|
client.destroy();
|
|
setTimeout(common.mustCall(() => {
|
|
sessionCb();
|
|
server.close();
|
|
}), 100);
|
|
}
|