mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 00:27:26 +00:00
42dbaed460
This introduces TLS1.3 support and makes it the default max protocol,
but also supports CLI/NODE_OPTIONS switches to disable it if necessary.
TLS1.3 is a major update to the TLS protocol, with many security
enhancements. It should be preferred over TLS1.2 whenever possible.
TLS1.3 is different enough that even though the OpenSSL APIs are
technically API/ABI compatible, that when TLS1.3 is negotiated, the
timing of protocol records and of callbacks broke assumptions hard-coded
into the 'tls' module.
This change introduces no API incompatibilities when TLS1.2 is
negotiated. It is the intention that it be backported to current and LTS
release lines with the default maximum TLS protocol reset to 'TLSv1.2'.
This will allow users of those lines to explicitly enable TLS1.3 if they
want.
API incompatibilities between TLS1.2 and TLS1.3 are:
- Renegotiation is not supported by TLS1.3 protocol, attempts to call
`.renegotiate()` will always fail.
- Compiling against a system OpenSSL lower than 1.1.1 is no longer
supported (OpenSSL-1.1.0 used to be supported with configure flags).
- Variations of `conn.write('data'); conn.destroy()` have undefined
behaviour according to the streams API. They may or may not send the
'data', and may or may not cause a ERR_STREAM_DESTROYED error to be
emitted. This has always been true, but conditions under which the write
suceeds is slightly but observably different when TLS1.3 is negotiated
vs when TLS1.2 or below is negotiated.
- If TLS1.3 is negotiated, and a server calls `conn.end()` in its
'secureConnection' listener without any data being written, the client
will not receive session tickets (no 'session' events will be emitted,
and `conn.getSession()` will never return a resumable session).
- The return value of `conn.getSession()` API may not return a resumable
session if called right after the handshake. The effect will be that
clients using the legacy `getSession()` API will resume sessions if
TLS1.2 is negotiated, but will do full handshakes if TLS1.3 is
negotiated. See https://github.com/nodejs/node/pull/25831 for more
information.
PR-URL: https://github.com/nodejs/node/pull/26209
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
98 lines
2.4 KiB
JavaScript
98 lines
2.4 KiB
JavaScript
// Flags: --tls-min-v1.0
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
const { readKey } = require('../common/fixtures');
|
|
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
const assert = require('assert');
|
|
const https = require('https');
|
|
const { OPENSSL_VERSION_NUMBER, SSL_OP_NO_TICKET } =
|
|
require('crypto').constants;
|
|
|
|
const options = {
|
|
key: readKey('agent1-key.pem'),
|
|
cert: readKey('agent1-cert.pem'),
|
|
secureOptions: SSL_OP_NO_TICKET
|
|
};
|
|
|
|
// Create TLS1.2 server
|
|
https.createServer(options, function(req, res) {
|
|
res.end('ohai');
|
|
}).listen(0, function() {
|
|
first(this);
|
|
});
|
|
|
|
// Do request and let agent cache the session
|
|
function first(server) {
|
|
const port = server.address().port;
|
|
const req = https.request({
|
|
port: port,
|
|
rejectUnauthorized: false
|
|
}, function(res) {
|
|
res.resume();
|
|
|
|
server.close(function() {
|
|
faultyServer(port);
|
|
});
|
|
});
|
|
req.end();
|
|
}
|
|
|
|
// Create TLS1 server
|
|
function faultyServer(port) {
|
|
options.secureProtocol = 'TLSv1_method';
|
|
https.createServer(options, function(req, res) {
|
|
res.end('hello faulty');
|
|
}).listen(port, function() {
|
|
second(this);
|
|
});
|
|
}
|
|
|
|
// Attempt to request using cached session
|
|
function second(server, session) {
|
|
const req = https.request({
|
|
port: server.address().port,
|
|
rejectUnauthorized: false
|
|
}, function(res) {
|
|
res.resume();
|
|
});
|
|
|
|
if (OPENSSL_VERSION_NUMBER >= 0x10100000) {
|
|
// Although we have a TLS 1.2 session to offer to the TLS 1.0 server,
|
|
// connection to the TLS 1.0 server should work.
|
|
req.on('response', common.mustCall(function(res) {
|
|
// The test is now complete for OpenSSL 1.1.0.
|
|
server.close();
|
|
}));
|
|
} else {
|
|
// OpenSSL 1.0.x mistakenly locked versions based on the session it was
|
|
// offering. This causes this sequent request to fail. Let it fail, but
|
|
// test that this is mitigated on the next try by invalidating the session.
|
|
req.on('error', common.mustCall(function(err) {
|
|
assert(/wrong version number/.test(err.message));
|
|
|
|
req.on('close', function() {
|
|
third(server);
|
|
});
|
|
}));
|
|
}
|
|
req.end();
|
|
}
|
|
|
|
// Try one more time - session should be evicted!
|
|
function third(server) {
|
|
const req = https.request({
|
|
port: server.address().port,
|
|
rejectUnauthorized: false
|
|
}, function(res) {
|
|
res.resume();
|
|
assert(!req.socket.isSessionReused());
|
|
server.close();
|
|
});
|
|
req.on('error', common.mustNotCall());
|
|
req.end();
|
|
}
|