mirror of
https://github.com/nodejs/node.git
synced 2025-04-30 23:56:58 +00:00

This introduces TLS1.3 support and makes it the default max protocol, but also supports CLI/NODE_OPTIONS switches to disable it if necessary. TLS1.3 is a major update to the TLS protocol, with many security enhancements. It should be preferred over TLS1.2 whenever possible. TLS1.3 is different enough that even though the OpenSSL APIs are technically API/ABI compatible, that when TLS1.3 is negotiated, the timing of protocol records and of callbacks broke assumptions hard-coded into the 'tls' module. This change introduces no API incompatibilities when TLS1.2 is negotiated. It is the intention that it be backported to current and LTS release lines with the default maximum TLS protocol reset to 'TLSv1.2'. This will allow users of those lines to explicitly enable TLS1.3 if they want. API incompatibilities between TLS1.2 and TLS1.3 are: - Renegotiation is not supported by TLS1.3 protocol, attempts to call `.renegotiate()` will always fail. - Compiling against a system OpenSSL lower than 1.1.1 is no longer supported (OpenSSL-1.1.0 used to be supported with configure flags). - Variations of `conn.write('data'); conn.destroy()` have undefined behaviour according to the streams API. They may or may not send the 'data', and may or may not cause a ERR_STREAM_DESTROYED error to be emitted. This has always been true, but conditions under which the write suceeds is slightly but observably different when TLS1.3 is negotiated vs when TLS1.2 or below is negotiated. - If TLS1.3 is negotiated, and a server calls `conn.end()` in its 'secureConnection' listener without any data being written, the client will not receive session tickets (no 'session' events will be emitted, and `conn.getSession()` will never return a resumable session). - The return value of `conn.getSession()` API may not return a resumable session if called right after the handshake. The effect will be that clients using the legacy `getSession()` API will resume sessions if TLS1.2 is negotiated, but will do full handshakes if TLS1.3 is negotiated. See https://github.com/nodejs/node/pull/25831 for more information. PR-URL: https://github.com/nodejs/node/pull/26209 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
140 lines
4.3 KiB
JavaScript
140 lines
4.3 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
const assert = require('assert');
|
|
const fixtures = require('../common/fixtures');
|
|
const tls = require('tls');
|
|
|
|
const tick = require('../common/tick');
|
|
const initHooks = require('./init-hooks');
|
|
const { checkInvocations } = require('./hook-checks');
|
|
|
|
const hooks = initHooks();
|
|
hooks.enable();
|
|
|
|
// TODO(@sam-github) assumes server handshake completes before client, true for
|
|
// 1.2, not for 1.3. Might need a rewrite for TLS1.3.
|
|
tls.DEFAULT_MAX_VERSION = 'TLSv1.2';
|
|
|
|
//
|
|
// Creating server and listening on port
|
|
//
|
|
const server = tls
|
|
.createServer({
|
|
cert: fixtures.readSync('test_cert.pem'),
|
|
key: fixtures.readSync('test_key.pem')
|
|
})
|
|
.on('listening', common.mustCall(onlistening))
|
|
.on('secureConnection', common.mustCall(onsecureConnection))
|
|
.listen(0);
|
|
|
|
let svr, client;
|
|
function onlistening() {
|
|
//
|
|
// Creating client and connecting it to server
|
|
//
|
|
tls
|
|
.connect(server.address().port, { rejectUnauthorized: false })
|
|
.on('secureConnect', common.mustCall(onsecureConnect));
|
|
|
|
const as = hooks.activitiesOfTypes('TLSWRAP');
|
|
assert.strictEqual(as.length, 1);
|
|
svr = as[0];
|
|
|
|
assert.strictEqual(svr.type, 'TLSWRAP');
|
|
assert.strictEqual(typeof svr.uid, 'number');
|
|
assert.strictEqual(typeof svr.triggerAsyncId, 'number');
|
|
checkInvocations(svr, { init: 1 }, 'server: when client connecting');
|
|
}
|
|
|
|
function onsecureConnection() {
|
|
//
|
|
// Server received client connection
|
|
//
|
|
const as = hooks.activitiesOfTypes('TLSWRAP');
|
|
assert.strictEqual(as.length, 2);
|
|
// TODO(@sam-github) This happens after onsecureConnect, with TLS1.3.
|
|
client = as[1];
|
|
assert.strictEqual(client.type, 'TLSWRAP');
|
|
assert.strictEqual(typeof client.uid, 'number');
|
|
assert.strictEqual(typeof client.triggerAsyncId, 'number');
|
|
|
|
// TODO(thlorenz) which callback did the server wrap execute that already
|
|
// finished as well?
|
|
checkInvocations(svr, { init: 1, before: 1, after: 1 },
|
|
'server: when server has secure connection');
|
|
|
|
checkInvocations(client, { init: 1, before: 2, after: 1 },
|
|
'client: when server has secure connection');
|
|
}
|
|
|
|
function onsecureConnect() {
|
|
//
|
|
// Client connected to server
|
|
//
|
|
checkInvocations(svr, { init: 1, before: 2, after: 1 },
|
|
'server: when client connected');
|
|
checkInvocations(client, { init: 1, before: 2, after: 2 },
|
|
'client: when client connected');
|
|
|
|
//
|
|
// Destroying client socket
|
|
//
|
|
this.destroy(); // This destroys client before server handshakes, with TLS1.3
|
|
checkInvocations(svr, { init: 1, before: 2, after: 1 },
|
|
'server: when destroying client');
|
|
checkInvocations(client, { init: 1, before: 2, after: 2 },
|
|
'client: when destroying client');
|
|
|
|
tick(5, tick1);
|
|
function tick1() {
|
|
checkInvocations(svr, { init: 1, before: 2, after: 2 },
|
|
'server: when client destroyed');
|
|
// TODO: why is client not destroyed here even after 5 ticks?
|
|
// or could it be that it isn't actually destroyed until
|
|
// the server is closed?
|
|
if (client.before.length < 3) {
|
|
tick(5, tick1);
|
|
return;
|
|
}
|
|
checkInvocations(client, { init: 1, before: 3, after: 3 },
|
|
'client: when client destroyed');
|
|
//
|
|
// Closing server
|
|
//
|
|
server.close(common.mustCall(onserverClosed));
|
|
// No changes to invocations until server actually closed below
|
|
checkInvocations(svr, { init: 1, before: 2, after: 2 },
|
|
'server: when closing server');
|
|
checkInvocations(client, { init: 1, before: 3, after: 3 },
|
|
'client: when closing server');
|
|
}
|
|
}
|
|
|
|
function onserverClosed() {
|
|
//
|
|
// Server closed
|
|
//
|
|
tick(1E4, common.mustCall(() => {
|
|
checkInvocations(svr, { init: 1, before: 2, after: 2 },
|
|
'server: when server closed');
|
|
checkInvocations(client, { init: 1, before: 3, after: 3 },
|
|
'client: when server closed');
|
|
}));
|
|
}
|
|
|
|
process.on('exit', onexit);
|
|
|
|
function onexit() {
|
|
hooks.disable();
|
|
hooks.sanityCheck('TLSWRAP');
|
|
|
|
checkInvocations(svr, { init: 1, before: 2, after: 2 },
|
|
'server: when process exits');
|
|
checkInvocations(client, { init: 1, before: 3, after: 3 },
|
|
'client: when process exits');
|
|
}
|