mirror of
https://github.com/nodejs/node.git
synced 2025-05-08 02:52:29 +00:00
380929ec0c
This change removes `common.noop` from the Node.js internal testing
common module.
Over the last few weeks, I've grown to dislike the `common.noop`
abstraction.
First, new (and experienced) contributors are unaware of it and so it
results in a large number of low-value nits on PRs. It also increases
the number of things newcomers and infrequent contributors have to be
aware of to be effective on the project.
Second, it is confusing. Is it a singleton/property or a getter? Which
should be expected? This can lead to subtle and hard-to-find bugs. (To
my knowledge, none have landed on master. But I also think it's only a
matter of time.)
Third, the abstraction is low-value in my opinion. What does it really
get us? A case could me made that it is without value at all.
Lastly, and this is minor, but the abstraction is wordier than not using
the abstraction. `common.noop` doesn't save anything over `() => {}`.
So, I propose removing it.
PR-URL: https://github.com/nodejs/node/pull/12822
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
65 lines
2.0 KiB
JavaScript
65 lines
2.0 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const URL = require('url').URL;
|
|
const path = require('path');
|
|
const assert = require('assert');
|
|
|
|
if (!common.hasIntl) {
|
|
// A handful of the tests fail when ICU is not included.
|
|
common.skip('missing Intl');
|
|
return;
|
|
}
|
|
|
|
// Tests below are not from WPT.
|
|
const tests = require(path.join(common.fixturesDir, 'url-tests'));
|
|
const failureTests = tests.filter((test) => test.failure).concat([
|
|
{ input: '' },
|
|
{ input: 'test' },
|
|
{ input: undefined },
|
|
{ input: 0 },
|
|
{ input: true },
|
|
{ input: false },
|
|
{ input: null },
|
|
{ input: new Date() },
|
|
{ input: new RegExp() },
|
|
{ input: () => {} }
|
|
]);
|
|
|
|
const expectedError = common.expectsError(
|
|
{ code: 'ERR_INVALID_URL', type: TypeError });
|
|
|
|
for (const test of failureTests) {
|
|
assert.throws(
|
|
() => new URL(test.input, test.base),
|
|
(error) => {
|
|
if (!expectedError(error))
|
|
return false;
|
|
|
|
// The input could be processed, so we don't do strict matching here
|
|
const match = (error + '').match(/Invalid URL: (.*)$/);
|
|
if (!match) {
|
|
return false;
|
|
}
|
|
return error.input === match[1];
|
|
});
|
|
}
|
|
|
|
const additional_tests = require(
|
|
path.join(common.fixturesDir, 'url-tests-additional.js'));
|
|
|
|
for (const test of additional_tests) {
|
|
const url = new URL(test.url);
|
|
if (test.href) assert.strictEqual(url.href, test.href);
|
|
if (test.origin) assert.strictEqual(url.origin, test.origin);
|
|
if (test.protocol) assert.strictEqual(url.protocol, test.protocol);
|
|
if (test.username) assert.strictEqual(url.username, test.username);
|
|
if (test.password) assert.strictEqual(url.password, test.password);
|
|
if (test.hostname) assert.strictEqual(url.hostname, test.hostname);
|
|
if (test.host) assert.strictEqual(url.host, test.host);
|
|
if (test.port !== undefined) assert.strictEqual(url.port, test.port);
|
|
if (test.pathname) assert.strictEqual(url.pathname, test.pathname);
|
|
if (test.search) assert.strictEqual(url.search, test.search);
|
|
if (test.hash) assert.strictEqual(url.hash, test.hash);
|
|
}
|