mirror of
https://github.com/nodejs/node.git
synced 2025-05-05 15:13:21 +00:00
380929ec0c
This change removes `common.noop` from the Node.js internal testing
common module.
Over the last few weeks, I've grown to dislike the `common.noop`
abstraction.
First, new (and experienced) contributors are unaware of it and so it
results in a large number of low-value nits on PRs. It also increases
the number of things newcomers and infrequent contributors have to be
aware of to be effective on the project.
Second, it is confusing. Is it a singleton/property or a getter? Which
should be expected? This can lead to subtle and hard-to-find bugs. (To
my knowledge, none have landed on master. But I also think it's only a
matter of time.)
Third, the abstraction is low-value in my opinion. What does it really
get us? A case could me made that it is without value at all.
Lastly, and this is minor, but the abstraction is wordier than not using
the abstraction. `common.noop` doesn't save anything over `() => {}`.
So, I propose removing it.
PR-URL: https://github.com/nodejs/node/pull/12822
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
88 lines
2.4 KiB
JavaScript
88 lines
2.4 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const vm = require('vm');
|
|
|
|
const spawn = require('child_process').spawn;
|
|
|
|
const methods = [
|
|
'runInThisContext',
|
|
'runInContext'
|
|
];
|
|
|
|
if (common.isWindows) {
|
|
// No way to send CTRL_C_EVENT to processes from JS right now.
|
|
common.skip('platform not supported');
|
|
return;
|
|
}
|
|
|
|
if (process.argv[2] === 'child') {
|
|
const method = process.argv[3];
|
|
assert.ok(method);
|
|
|
|
let firstHandlerCalled = 0;
|
|
process.on('SIGINT', common.mustCall(() => {
|
|
firstHandlerCalled++;
|
|
// Handler attached _before_ execution.
|
|
}, 2));
|
|
|
|
let onceHandlerCalled = 0;
|
|
process.once('SIGINT', common.mustCall(() => {
|
|
onceHandlerCalled++;
|
|
// Handler attached _before_ execution.
|
|
}));
|
|
|
|
const script = `process.send('${method}'); while(true) {}`;
|
|
const args = method === 'runInContext' ?
|
|
[vm.createContext({ process })] :
|
|
[];
|
|
const options = { breakOnSigint: true };
|
|
|
|
assert.throws(() => { vm[method](script, ...args, options); },
|
|
/^Error: Script execution interrupted\.$/);
|
|
assert.strictEqual(firstHandlerCalled, 0);
|
|
assert.strictEqual(onceHandlerCalled, 0);
|
|
|
|
// Keep the process alive for a while so that the second SIGINT can be caught.
|
|
const timeout = setTimeout(() => {}, 1000);
|
|
|
|
let afterHandlerCalled = 0;
|
|
|
|
process.on('SIGINT', common.mustCall(() => {
|
|
// Handler attached _after_ execution.
|
|
if (afterHandlerCalled++ === 0) {
|
|
// The first time it just bounces back to check that the `once()`
|
|
// handler is not called the second time.
|
|
assert.strictEqual(firstHandlerCalled, 1);
|
|
assert.strictEqual(onceHandlerCalled, 1);
|
|
process.send(method);
|
|
return;
|
|
}
|
|
|
|
assert.strictEqual(onceHandlerCalled, 1);
|
|
assert.strictEqual(firstHandlerCalled, 2);
|
|
timeout.unref();
|
|
}, 2));
|
|
|
|
process.send(method);
|
|
|
|
return;
|
|
}
|
|
|
|
for (const method of methods) {
|
|
const child = spawn(process.execPath, [__filename, 'child', method], {
|
|
stdio: [null, 'inherit', 'inherit', 'ipc']
|
|
});
|
|
|
|
child.on('message', common.mustCall(() => {
|
|
// First kill() breaks the while(true) loop, second one invokes the real
|
|
// signal handlers.
|
|
process.kill(child.pid, 'SIGINT');
|
|
}, 3));
|
|
|
|
child.on('close', common.mustCall((code, signal) => {
|
|
assert.strictEqual(signal, null);
|
|
assert.strictEqual(code, 0);
|
|
}));
|
|
}
|