mirror of
https://github.com/nodejs/node.git
synced 2025-05-09 18:02:21 +00:00
659dadd410
The GlobalPropertyQueryCallback was changed in 2010 to return an integer instead of a boolean: https://groups.google.com/forum/#!topic/v8-users/OOjHJrix-cU This integer communicates the property descriptors of the property, instead of just its presence or absence. However, the original contextify code was probably written before this change, and it was not updated when porting to Node.js. Credit to @smikes for the test and the original PR of #885. Fixes: https://github.com/nodejs/io.js/pull/864 Fixes: https://github.com/nodejs/io.js/pull/885 PR-URL: https://github.com/nodejs/io.js/pull/1773 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
26 lines
648 B
JavaScript
26 lines
648 B
JavaScript
'use strict';
|
|
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
|
|
var vm = require('vm');
|
|
|
|
var x = {};
|
|
Object.defineProperty(x, 'prop', {
|
|
configurable: false,
|
|
enumerable: false,
|
|
writable: false,
|
|
value: 'val'
|
|
});
|
|
var o = vm.createContext(x);
|
|
|
|
var code = 'Object.getOwnPropertyDescriptor(this, "prop")';
|
|
var res = vm.runInContext(code, o, 'test');
|
|
|
|
assert(res);
|
|
assert.equal(typeof res, 'object');
|
|
assert.equal(res.value, 'val');
|
|
assert.equal(res.configurable, false, 'should not be configurable');
|
|
assert.equal(res.enumerable, false, 'should not be enumerable');
|
|
assert.equal(res.writable, false, 'should not be writable');
|