mirror of
https://github.com/nodejs/node.git
synced 2025-04-29 06:19:07 +00:00
362694401f
The old error name and message were trying to be consistent with ERR_BUFFER_TOO_LARGE but they were not really accurate. The kStringMaxLength was measured in number of characters, not number of bytes. The name ERR_STRING_TOO_LARGE also seems a bit awkward. This patch tries to correct them before they get released to users. PR-URL: https://github.com/nodejs/node/pull/19864 Refs: https://github.com/nodejs/node/pull/19739 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
54 lines
1.5 KiB
JavaScript
54 lines
1.5 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../../common');
|
|
const skipMessage = 'intensive toString tests due to memory confinements';
|
|
if (!common.enoughTestMem)
|
|
common.skip(skipMessage);
|
|
|
|
const binding = require(`./build/${common.buildType}/binding`);
|
|
const assert = require('assert');
|
|
|
|
// v8 fails silently if string length > v8::String::kMaxLength
|
|
// v8::String::kMaxLength defined in v8.h
|
|
const kStringMaxLength = process.binding('buffer').kStringMaxLength;
|
|
|
|
let buf;
|
|
try {
|
|
buf = Buffer.allocUnsafe(kStringMaxLength + 1);
|
|
} catch (e) {
|
|
// If the exception is not due to memory confinement then rethrow it.
|
|
if (e.message !== 'Array buffer allocation failed') throw (e);
|
|
common.skip(skipMessage);
|
|
}
|
|
|
|
// Ensure we have enough memory available for future allocations to succeed.
|
|
if (!binding.ensureAllocation(2 * kStringMaxLength))
|
|
common.skip(skipMessage);
|
|
|
|
const stringLengthHex = kStringMaxLength.toString(16);
|
|
|
|
assert.throws(function() {
|
|
buf.toString();
|
|
}, function(e) {
|
|
if (e.message !== 'Array buffer allocation failed') {
|
|
common.expectsError({
|
|
message: `Cannot create a string longer than 0x${stringLengthHex} ` +
|
|
'characters',
|
|
code: 'ERR_STRING_TOO_LONG',
|
|
type: Error
|
|
})(e);
|
|
return true;
|
|
} else {
|
|
return true;
|
|
}
|
|
});
|
|
|
|
common.expectsError(function() {
|
|
buf.toString('utf8');
|
|
}, {
|
|
message: `Cannot create a string longer than 0x${stringLengthHex} ` +
|
|
'characters',
|
|
code: 'ERR_STRING_TOO_LONG',
|
|
type: Error
|
|
});
|