mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 09:23:11 +00:00
357f904169
When `maybeReadMore` kicks in on a first bytes of incoming data, the `req.read(0)` will be invoked and the `req._consuming` will be set to `true`. This seemingly harmless property leads to a dire consequences: the server won't call `req._dump()` and the whole HTTP/1.1 pipeline will hang (single connection). PR-URL: https://github.com/nodejs/node/pull/7211 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
52 lines
1.1 KiB
JavaScript
52 lines
1.1 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const http = require('http');
|
|
|
|
let onPause = null;
|
|
|
|
const server = http.createServer((req, res) => {
|
|
if (req.method === 'GET')
|
|
return res.end();
|
|
|
|
res.writeHead(200);
|
|
res.flushHeaders();
|
|
|
|
req.connection.on('pause', () => {
|
|
res.end();
|
|
onPause();
|
|
});
|
|
}).listen(common.PORT, common.mustCall(() => {
|
|
const agent = new http.Agent({
|
|
maxSockets: 1,
|
|
keepAlive: true
|
|
});
|
|
|
|
const post = http.request({
|
|
agent: agent,
|
|
method: 'POST',
|
|
port: common.PORT,
|
|
}, common.mustCall((res) => {
|
|
res.resume();
|
|
|
|
post.write(Buffer.alloc(16 * 1024).fill('X'));
|
|
onPause = () => {
|
|
post.end('something');
|
|
};
|
|
}));
|
|
|
|
/* What happens here is that the server `end`s the response before we send
|
|
* `something`, and the client thought that this is a green light for sending
|
|
* next GET request
|
|
*/
|
|
post.write('initial');
|
|
|
|
http.request({
|
|
agent: agent,
|
|
method: 'GET',
|
|
port: common.PORT,
|
|
}, common.mustCall((res) => {
|
|
server.close();
|
|
res.connection.end();
|
|
})).end();
|
|
}));
|