mirror of
https://github.com/nodejs/node.git
synced 2025-05-21 14:39:17 +00:00
8caa1dcee6
There are several cleanups here that are not just style nits... 1. The `common.isMainThread` was just a passthrough to the `isMainThread` export on the worker_thread module. It's use was inconsistent and just obfuscated the fact that the test file depend on the `worker_threads` built-in. By eliminating it we simplify the test harness a bit and make it clearer which tests depend on the worker_threads check. 2. The `common.isDumbTerminal` is fairly unnecesary since that just wraps a public API check. 3. Several of the `common.skipIf....` checks were inconsistently used and really don't need to be separate utility functions. A key part of the motivation here is to work towards making more of the tests more self-contained and less reliant on the common test harness where possible. PR-URL: https://github.com/nodejs/node/pull/56712 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
74 lines
1.9 KiB
JavaScript
74 lines
1.9 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const fixtures = require('../common/fixtures');
|
|
const assert = require('assert');
|
|
const net = require('net');
|
|
const { isMainThread } = require('worker_threads');
|
|
|
|
if (!isMainThread) {
|
|
common.skip('process.chdir is not available in Workers');
|
|
}
|
|
|
|
process.chdir(fixtures.fixturesDir);
|
|
const repl = require('repl');
|
|
|
|
{
|
|
const server = net.createServer((conn) => {
|
|
repl.start('', conn).on('exit', () => {
|
|
conn.destroy();
|
|
server.close();
|
|
});
|
|
});
|
|
|
|
const host = common.localhostIPv4;
|
|
const port = 0;
|
|
const options = { host, port };
|
|
|
|
let answer = '';
|
|
server.listen(options, function() {
|
|
options.port = this.address().port;
|
|
const conn = net.connect(options);
|
|
conn.setEncoding('utf8');
|
|
conn.on('data', (data) => answer += data);
|
|
conn.write('require("baz")\nrequire("./baz")\n.exit\n');
|
|
});
|
|
|
|
process.on('exit', function() {
|
|
assert.doesNotMatch(answer, /Cannot find module/);
|
|
assert.doesNotMatch(answer, /Error/);
|
|
assert.strictEqual(answer, '\'eye catcher\'\n\'perhaps I work\'\n');
|
|
});
|
|
}
|
|
|
|
// Test for https://github.com/nodejs/node/issues/30808
|
|
// In REPL, we shouldn't look up relative modules from 'node_modules'.
|
|
{
|
|
const server = net.createServer((conn) => {
|
|
repl.start('', conn).on('exit', () => {
|
|
conn.destroy();
|
|
server.close();
|
|
});
|
|
});
|
|
|
|
const host = common.localhostIPv4;
|
|
const port = 0;
|
|
const options = { host, port };
|
|
|
|
let answer = '';
|
|
server.listen(options, function() {
|
|
options.port = this.address().port;
|
|
const conn = net.connect(options);
|
|
conn.setEncoding('utf8');
|
|
conn.on('data', (data) => answer += data);
|
|
conn.write('require("./bar")\n.exit\n');
|
|
});
|
|
|
|
process.on('exit', function() {
|
|
assert.match(answer, /Uncaught Error: Cannot find module '\.\/bar'/);
|
|
|
|
assert.match(answer, /code: 'MODULE_NOT_FOUND'/);
|
|
assert.match(answer, /requireStack: \[ '<repl>' \]/);
|
|
});
|
|
}
|