mirror of
https://github.com/nodejs/node.git
synced 2025-04-29 06:19:07 +00:00

There are several cleanups here that are not just style nits... 1. The `common.isMainThread` was just a passthrough to the `isMainThread` export on the worker_thread module. It's use was inconsistent and just obfuscated the fact that the test file depend on the `worker_threads` built-in. By eliminating it we simplify the test harness a bit and make it clearer which tests depend on the worker_threads check. 2. The `common.isDumbTerminal` is fairly unnecesary since that just wraps a public API check. 3. Several of the `common.skipIf....` checks were inconsistently used and really don't need to be separate utility functions. A key part of the motivation here is to work towards making more of the tests more self-contained and less reliant on the common test harness where possible. PR-URL: https://github.com/nodejs/node/pull/56712 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
35 lines
931 B
JavaScript
35 lines
931 B
JavaScript
// Flags: --permission --allow-fs-read=* --allow-child-process
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
const { isMainThread } = require('worker_threads');
|
|
|
|
if (!isMainThread) {
|
|
common.skip('This test only works on a main thread');
|
|
}
|
|
|
|
const assert = require('assert');
|
|
const { spawnSync } = require('child_process');
|
|
|
|
{
|
|
// Relative path as CLI args are supported
|
|
const { status, stdout } = spawnSync(
|
|
process.execPath,
|
|
[
|
|
'--permission',
|
|
'--allow-fs-read', '*',
|
|
'--allow-fs-write', '../fixtures/permission/deny/regular-file.md',
|
|
'-e',
|
|
`
|
|
const path = require("path");
|
|
const absolutePath = path.resolve("../fixtures/permission/deny/regular-file.md");
|
|
console.log(process.permission.has("fs.write", absolutePath));
|
|
`,
|
|
]
|
|
);
|
|
|
|
const [fsWrite] = stdout.toString().split('\n');
|
|
assert.strictEqual(fsWrite, 'true');
|
|
assert.strictEqual(status, 0);
|
|
}
|