mirror of
https://github.com/nodejs/node.git
synced 2025-04-29 22:40:57 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
38 lines
986 B
JavaScript
38 lines
986 B
JavaScript
'use strict';
|
|
|
|
// This tests that the error thrown from net.createConnection
|
|
// comes with host and port properties.
|
|
// See https://github.com/nodejs/node-v0.x-archive/issues/7005
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const net = require('net');
|
|
|
|
const { addresses } = require('../common/internet');
|
|
const {
|
|
errorLookupMock,
|
|
mockedErrorCode
|
|
} = require('../common/dns');
|
|
|
|
// Using port 0 as hostname used is already invalid.
|
|
const c = net.createConnection({
|
|
port: 0,
|
|
host: addresses.INVALID_HOST,
|
|
lookup: common.mustCall(errorLookupMock())
|
|
});
|
|
|
|
c.on('connect', common.mustNotCall());
|
|
|
|
c.on('error', common.mustCall((error) => {
|
|
assert.ok(!('port' in error));
|
|
assert.ok(!('host' in error));
|
|
assert.throws(() => { throw error; }, {
|
|
errno: mockedErrorCode,
|
|
code: mockedErrorCode,
|
|
name: 'Error',
|
|
message: 'getaddrinfo ENOTFOUND something.invalid',
|
|
hostname: addresses.INVALID_HOST,
|
|
syscall: 'getaddrinfo'
|
|
});
|
|
}));
|