mirror of
https://github.com/nodejs/node.git
synced 2025-04-28 21:46:48 +00:00
1ed3c54ecb
This updates all Node.js errors by removing the `code` being part of the `name` property. Instead, the name is just changed once on instantiation, the stack is accessed to create the stack as expected and then the `name` property is set back to it's original form. PR-URL: https://github.com/nodejs/node/pull/26738 Fixes: https://github.com/nodejs/node/issues/26669 Fixes: https://github.com/nodejs/node/issues/20253 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
36 lines
922 B
JavaScript
36 lines
922 B
JavaScript
// Flags: --expose-internals
|
|
|
|
'use strict';
|
|
|
|
// This tests `internal/errors.useOriginalName`
|
|
// This testing feature is needed to allows us to assert the types of
|
|
// errors without using instanceof, which is necessary in WPT harness.
|
|
// Refs: https://github.com/nodejs/node/pull/22556
|
|
|
|
require('../common');
|
|
const assert = require('assert');
|
|
const errors = require('internal/errors');
|
|
|
|
|
|
errors.E('TEST_ERROR_1', 'Error for testing purposes: %s',
|
|
Error);
|
|
{
|
|
const err = new errors.codes.TEST_ERROR_1('test');
|
|
assert(err instanceof Error);
|
|
assert.strictEqual(err.name, 'Error');
|
|
}
|
|
|
|
{
|
|
errors.useOriginalName = true;
|
|
const err = new errors.codes.TEST_ERROR_1('test');
|
|
assert(err instanceof Error);
|
|
assert.strictEqual(err.name, 'Error');
|
|
}
|
|
|
|
{
|
|
errors.useOriginalName = false;
|
|
const err = new errors.codes.TEST_ERROR_1('test');
|
|
assert(err instanceof Error);
|
|
assert.strictEqual(err.name, 'Error');
|
|
}
|