mirror of
https://github.com/nodejs/node.git
synced 2025-04-29 14:25:18 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
25 lines
726 B
JavaScript
25 lines
726 B
JavaScript
// Flags: --expose-internals
|
|
'use strict';
|
|
|
|
require('../common');
|
|
const assert = require('assert');
|
|
|
|
// Tests the assertValidPseudoHeader function that is used within the
|
|
// mapToHeaders function. The assert function is not exported so we
|
|
// have to test it through mapToHeaders
|
|
|
|
const { mapToHeaders } = require('internal/http2/util');
|
|
|
|
// These should not throw
|
|
mapToHeaders({ ':status': 'a' });
|
|
mapToHeaders({ ':path': 'a' });
|
|
mapToHeaders({ ':authority': 'a' });
|
|
mapToHeaders({ ':scheme': 'a' });
|
|
mapToHeaders({ ':method': 'a' });
|
|
|
|
assert.throws(() => mapToHeaders({ ':foo': 'a' }), {
|
|
code: 'ERR_HTTP2_INVALID_PSEUDOHEADER',
|
|
name: 'TypeError',
|
|
message: '":foo" is an invalid pseudoheader or is used incorrectly'
|
|
});
|