mirror of
https://github.com/nodejs/node.git
synced 2025-04-29 14:25:18 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
73 lines
2.1 KiB
JavaScript
73 lines
2.1 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const http2 = require('http2');
|
|
const Countdown = require('../common/countdown');
|
|
|
|
// Check that pushStream handles method HEAD correctly
|
|
// - stream should end immediately (no body)
|
|
|
|
const server = http2.createServer();
|
|
server.on('stream', common.mustCall((stream, headers) => {
|
|
const port = server.address().port;
|
|
if (headers[':path'] === '/') {
|
|
stream.pushStream({
|
|
':scheme': 'http',
|
|
':method': 'HEAD',
|
|
':authority': `localhost:${port}`,
|
|
}, common.mustCall((err, push, headers) => {
|
|
assert.strictEqual(push._writableState.ended, true);
|
|
push.respond();
|
|
// Cannot write to push() anymore
|
|
push.on('error', common.expectsError({
|
|
name: 'Error',
|
|
code: 'ERR_STREAM_WRITE_AFTER_END',
|
|
message: 'write after end'
|
|
}));
|
|
assert(!push.write('test'));
|
|
stream.end('test');
|
|
}));
|
|
}
|
|
stream.respond({
|
|
'content-type': 'text/html',
|
|
':status': 200
|
|
});
|
|
}));
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const port = server.address().port;
|
|
const client = http2.connect(`http://localhost:${port}`);
|
|
|
|
const countdown = new Countdown(2, () => {
|
|
server.close();
|
|
client.close();
|
|
});
|
|
|
|
const req = client.request();
|
|
req.setEncoding('utf8');
|
|
|
|
client.on('stream', common.mustCall((stream, headers) => {
|
|
assert.strictEqual(headers[':method'], 'HEAD');
|
|
assert.strictEqual(headers[':scheme'], 'http');
|
|
assert.strictEqual(headers[':path'], '/');
|
|
assert.strictEqual(headers[':authority'], `localhost:${port}`);
|
|
stream.on('push', common.mustCall(() => {
|
|
stream.on('data', common.mustNotCall());
|
|
stream.on('end', common.mustCall());
|
|
}));
|
|
stream.on('close', common.mustCall(() => countdown.dec()));
|
|
}));
|
|
|
|
let data = '';
|
|
|
|
req.on('data', common.mustCall((d) => data += d));
|
|
req.on('end', common.mustCall(() => {
|
|
assert.strictEqual(data, 'test');
|
|
}));
|
|
req.on('close', common.mustCall(() => countdown.dec()));
|
|
req.end();
|
|
}));
|