mirror of
https://github.com/nodejs/node.git
synced 2025-04-29 06:19:07 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
55 lines
1.4 KiB
JavaScript
55 lines
1.4 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const http2 = require('http2');
|
|
|
|
const server = http2.createServer();
|
|
|
|
server.on('session', common.mustCall((session) => {
|
|
// Verify that the settings disabling push is received
|
|
session.on('remoteSettings', common.mustCall((settings) => {
|
|
assert.strictEqual(settings.enablePush, false);
|
|
}));
|
|
}));
|
|
|
|
server.on('stream', common.mustCall((stream) => {
|
|
|
|
// The client has disabled push streams, so pushAllowed must be false,
|
|
// and pushStream() must throw.
|
|
assert.strictEqual(stream.pushAllowed, false);
|
|
|
|
assert.throws(() => {
|
|
stream.pushStream({
|
|
':scheme': 'http',
|
|
':path': '/foobar',
|
|
':authority': `localhost:${server.address().port}`,
|
|
}, common.mustNotCall());
|
|
}, {
|
|
code: 'ERR_HTTP2_PUSH_DISABLED',
|
|
name: 'Error'
|
|
});
|
|
|
|
stream.respond({ ':status': 200 });
|
|
stream.end('test');
|
|
}));
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const options = { settings: { enablePush: false } };
|
|
const client = http2.connect(`http://localhost:${server.address().port}`,
|
|
options);
|
|
const req = client.request({ ':path': '/' });
|
|
|
|
// Because push streams are disabled, this must not be called.
|
|
client.on('stream', common.mustNotCall());
|
|
|
|
req.resume();
|
|
req.on('end', common.mustCall(() => {
|
|
server.close();
|
|
client.close();
|
|
}));
|
|
req.end();
|
|
}));
|