mirror of
https://github.com/nodejs/node.git
synced 2025-05-08 16:29:55 +00:00
31147c4704
Do not write one character too much before shifting the whole result to the left when using UTF16-LE, possibly overwriting already-used memory while doing so. Fixes: https://github.com/nodejs/node/issues/26422 PR-URL: https://github.com/nodejs/node/pull/26432 Fixes: https://github.com/nodejs/node/issues/26422 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
102 lines
3.5 KiB
JavaScript
102 lines
3.5 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
|
|
const outsideBounds = common.expectsError({
|
|
code: 'ERR_BUFFER_OUT_OF_BOUNDS',
|
|
type: RangeError,
|
|
message: 'Attempt to write outside buffer bounds'
|
|
}, 2);
|
|
|
|
assert.throws(() => Buffer.alloc(9).write('foo', -1), outsideBounds);
|
|
assert.throws(() => Buffer.alloc(9).write('foo', 10), outsideBounds);
|
|
|
|
const resultMap = new Map([
|
|
['utf8', Buffer.from([102, 111, 111, 0, 0, 0, 0, 0, 0])],
|
|
['ucs2', Buffer.from([102, 0, 111, 0, 111, 0, 0, 0, 0])],
|
|
['ascii', Buffer.from([102, 111, 111, 0, 0, 0, 0, 0, 0])],
|
|
['latin1', Buffer.from([102, 111, 111, 0, 0, 0, 0, 0, 0])],
|
|
['binary', Buffer.from([102, 111, 111, 0, 0, 0, 0, 0, 0])],
|
|
['utf16le', Buffer.from([102, 0, 111, 0, 111, 0, 0, 0, 0])],
|
|
['base64', Buffer.from([102, 111, 111, 0, 0, 0, 0, 0, 0])],
|
|
['hex', Buffer.from([102, 111, 111, 0, 0, 0, 0, 0, 0])]
|
|
]);
|
|
|
|
// utf8, ucs2, ascii, latin1, utf16le
|
|
const encodings = ['utf8', 'utf-8', 'ucs2', 'ucs-2', 'ascii', 'latin1',
|
|
'binary', 'utf16le', 'utf-16le'];
|
|
|
|
encodings
|
|
.reduce((es, e) => es.concat(e, e.toUpperCase()), [])
|
|
.forEach((encoding) => {
|
|
const buf = Buffer.alloc(9);
|
|
const len = Buffer.byteLength('foo', encoding);
|
|
assert.strictEqual(buf.write('foo', 0, len, encoding), len);
|
|
|
|
if (encoding.includes('-'))
|
|
encoding = encoding.replace('-', '');
|
|
|
|
assert.deepStrictEqual(buf, resultMap.get(encoding.toLowerCase()));
|
|
});
|
|
|
|
// base64
|
|
['base64', 'BASE64'].forEach((encoding) => {
|
|
const buf = Buffer.alloc(9);
|
|
const len = Buffer.byteLength('Zm9v', encoding);
|
|
|
|
assert.strictEqual(buf.write('Zm9v', 0, len, encoding), len);
|
|
assert.deepStrictEqual(buf, resultMap.get(encoding.toLowerCase()));
|
|
});
|
|
|
|
// hex
|
|
['hex', 'HEX'].forEach((encoding) => {
|
|
const buf = Buffer.alloc(9);
|
|
const len = Buffer.byteLength('666f6f', encoding);
|
|
|
|
assert.strictEqual(buf.write('666f6f', 0, len, encoding), len);
|
|
assert.deepStrictEqual(buf, resultMap.get(encoding.toLowerCase()));
|
|
});
|
|
|
|
// Invalid encodings
|
|
for (let i = 1; i < 10; i++) {
|
|
const encoding = String(i).repeat(i);
|
|
const error = common.expectsError({
|
|
code: 'ERR_UNKNOWN_ENCODING',
|
|
type: TypeError,
|
|
message: `Unknown encoding: ${encoding}`
|
|
});
|
|
|
|
assert.ok(!Buffer.isEncoding(encoding));
|
|
assert.throws(() => Buffer.alloc(9).write('foo', encoding), error);
|
|
}
|
|
|
|
// UCS-2 overflow CVE-2018-12115
|
|
for (let i = 1; i < 4; i++) {
|
|
// Allocate two Buffers sequentially off the pool. Run more than once in case
|
|
// we hit the end of the pool and don't get sequential allocations
|
|
const x = Buffer.allocUnsafe(4).fill(0);
|
|
const y = Buffer.allocUnsafe(4).fill(1);
|
|
// Should not write anything, pos 3 doesn't have enough room for a 16-bit char
|
|
assert.strictEqual(x.write('ыыыыыы', 3, 'ucs2'), 0);
|
|
// CVE-2018-12115 experienced via buffer overrun to next block in the pool
|
|
assert.strictEqual(Buffer.compare(y, Buffer.alloc(4, 1)), 0);
|
|
}
|
|
|
|
// Should not write any data when there is no space for 16-bit chars
|
|
const z = Buffer.alloc(4, 0);
|
|
assert.strictEqual(z.write('\u0001', 3, 'ucs2'), 0);
|
|
assert.strictEqual(Buffer.compare(z, Buffer.alloc(4, 0)), 0);
|
|
|
|
// Large overrun could corrupt the process
|
|
assert.strictEqual(Buffer.alloc(4)
|
|
.write('ыыыыыы'.repeat(100), 3, 'utf16le'), 0);
|
|
|
|
{
|
|
// .write() does not affect the byte after the written-to slice of the Buffer.
|
|
// Refs: https://github.com/nodejs/node/issues/26422
|
|
const buf = Buffer.alloc(8);
|
|
assert.strictEqual(buf.write('ыы', 1, 'utf16le'), 4);
|
|
assert.deepStrictEqual([...buf], [0, 0x4b, 0x04, 0x4b, 0x04, 0, 0, 0]);
|
|
}
|