mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 20:29:36 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
85 lines
3.7 KiB
JavaScript
85 lines
3.7 KiB
JavaScript
'use strict';
|
|
|
|
// From: https://github.com/w3c/web-platform-tests/blob/39a67e2fff/encoding/textdecoder-fatal.html
|
|
// With the twist that we specifically test for Node.js error codes
|
|
|
|
const common = require('../common');
|
|
|
|
if (!common.hasIntl)
|
|
common.skip('missing Intl');
|
|
|
|
const assert = require('assert');
|
|
|
|
const bad = [
|
|
{ encoding: 'utf-8', input: [0xFF], name: 'invalid code' },
|
|
{ encoding: 'utf-8', input: [0xC0], name: 'ends early' },
|
|
{ encoding: 'utf-8', input: [0xE0], name: 'ends early 2' },
|
|
{ encoding: 'utf-8', input: [0xC0, 0x00], name: 'invalid trail' },
|
|
{ encoding: 'utf-8', input: [0xC0, 0xC0], name: 'invalid trail 2' },
|
|
{ encoding: 'utf-8', input: [0xE0, 0x00], name: 'invalid trail 3' },
|
|
{ encoding: 'utf-8', input: [0xE0, 0xC0], name: 'invalid trail 4' },
|
|
{ encoding: 'utf-8', input: [0xE0, 0x80, 0x00], name: 'invalid trail 5' },
|
|
{ encoding: 'utf-8', input: [0xE0, 0x80, 0xC0], name: 'invalid trail 6' },
|
|
{ encoding: 'utf-8', input: [0xFC, 0x80, 0x80, 0x80, 0x80, 0x80],
|
|
name: '> 0x10FFFF' },
|
|
{ encoding: 'utf-8', input: [0xFE, 0x80, 0x80, 0x80, 0x80, 0x80],
|
|
name: 'obsolete lead byte' },
|
|
// Overlong encodings
|
|
{ encoding: 'utf-8', input: [0xC0, 0x80], name: 'overlong U+0000 - 2 bytes' },
|
|
{ encoding: 'utf-8', input: [0xE0, 0x80, 0x80],
|
|
name: 'overlong U+0000 - 3 bytes' },
|
|
{ encoding: 'utf-8', input: [0xF0, 0x80, 0x80, 0x80],
|
|
name: 'overlong U+0000 - 4 bytes' },
|
|
{ encoding: 'utf-8', input: [0xF8, 0x80, 0x80, 0x80, 0x80],
|
|
name: 'overlong U+0000 - 5 bytes' },
|
|
{ encoding: 'utf-8', input: [0xFC, 0x80, 0x80, 0x80, 0x80, 0x80],
|
|
name: 'overlong U+0000 - 6 bytes' },
|
|
{ encoding: 'utf-8', input: [0xC1, 0xBF], name: 'overlong U+007F - 2 bytes' },
|
|
{ encoding: 'utf-8', input: [0xE0, 0x81, 0xBF],
|
|
name: 'overlong U+007F - 3 bytes' },
|
|
{ encoding: 'utf-8', input: [0xF0, 0x80, 0x81, 0xBF],
|
|
name: 'overlong U+007F - 4 bytes' },
|
|
{ encoding: 'utf-8', input: [0xF8, 0x80, 0x80, 0x81, 0xBF],
|
|
name: 'overlong U+007F - 5 bytes' },
|
|
{ encoding: 'utf-8', input: [0xFC, 0x80, 0x80, 0x80, 0x81, 0xBF],
|
|
name: 'overlong U+007F - 6 bytes' },
|
|
{ encoding: 'utf-8', input: [0xE0, 0x9F, 0xBF],
|
|
name: 'overlong U+07FF - 3 bytes' },
|
|
{ encoding: 'utf-8', input: [0xF0, 0x80, 0x9F, 0xBF],
|
|
name: 'overlong U+07FF - 4 bytes' },
|
|
{ encoding: 'utf-8', input: [0xF8, 0x80, 0x80, 0x9F, 0xBF],
|
|
name: 'overlong U+07FF - 5 bytes' },
|
|
{ encoding: 'utf-8', input: [0xFC, 0x80, 0x80, 0x80, 0x9F, 0xBF],
|
|
name: 'overlong U+07FF - 6 bytes' },
|
|
{ encoding: 'utf-8', input: [0xF0, 0x8F, 0xBF, 0xBF],
|
|
name: 'overlong U+FFFF - 4 bytes' },
|
|
{ encoding: 'utf-8', input: [0xF8, 0x80, 0x8F, 0xBF, 0xBF],
|
|
name: 'overlong U+FFFF - 5 bytes' },
|
|
{ encoding: 'utf-8', input: [0xFC, 0x80, 0x80, 0x8F, 0xBF, 0xBF],
|
|
name: 'overlong U+FFFF - 6 bytes' },
|
|
{ encoding: 'utf-8', input: [0xF8, 0x84, 0x8F, 0xBF, 0xBF],
|
|
name: 'overlong U+10FFFF - 5 bytes' },
|
|
{ encoding: 'utf-8', input: [0xFC, 0x80, 0x84, 0x8F, 0xBF, 0xBF],
|
|
name: 'overlong U+10FFFF - 6 bytes' },
|
|
// UTF-16 surrogates encoded as code points in UTF-8
|
|
{ encoding: 'utf-8', input: [0xED, 0xA0, 0x80], name: 'lead surrogate' },
|
|
{ encoding: 'utf-8', input: [0xED, 0xB0, 0x80], name: 'trail surrogate' },
|
|
{ encoding: 'utf-8', input: [0xED, 0xA0, 0x80, 0xED, 0xB0, 0x80],
|
|
name: 'surrogate pair' },
|
|
{ encoding: 'utf-16le', input: [0x00], name: 'truncated code unit' },
|
|
// Mismatched UTF-16 surrogates are exercised in utf16-surrogates.html
|
|
// FIXME: Add legacy encoding cases
|
|
];
|
|
|
|
bad.forEach((t) => {
|
|
assert.throws(
|
|
() => {
|
|
new TextDecoder(t.encoding, { fatal: true })
|
|
.decode(new Uint8Array(t.input));
|
|
}, {
|
|
code: 'ERR_ENCODING_INVALID_ENCODED_DATA',
|
|
name: 'TypeError'
|
|
}
|
|
);
|
|
});
|