mirror of
https://github.com/nodejs/node.git
synced 2025-05-04 06:05:22 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
50 lines
1.4 KiB
JavaScript
50 lines
1.4 KiB
JavaScript
'use strict';
|
|
require('../common');
|
|
const assert = require('assert');
|
|
|
|
function doSetTimeout(callback, after) {
|
|
return function() {
|
|
setTimeout(callback, after);
|
|
};
|
|
}
|
|
|
|
const errMessage = {
|
|
code: 'ERR_INVALID_CALLBACK',
|
|
name: 'TypeError'
|
|
};
|
|
|
|
assert.throws(doSetTimeout('foo'), errMessage);
|
|
assert.throws(doSetTimeout({ foo: 'bar' }), errMessage);
|
|
assert.throws(doSetTimeout(), errMessage);
|
|
assert.throws(doSetTimeout(undefined, 0), errMessage);
|
|
assert.throws(doSetTimeout(null, 0), errMessage);
|
|
assert.throws(doSetTimeout(false, 0), errMessage);
|
|
|
|
|
|
function doSetInterval(callback, after) {
|
|
return function() {
|
|
setInterval(callback, after);
|
|
};
|
|
}
|
|
|
|
assert.throws(doSetInterval('foo'), errMessage);
|
|
assert.throws(doSetInterval({ foo: 'bar' }), errMessage);
|
|
assert.throws(doSetInterval(), errMessage);
|
|
assert.throws(doSetInterval(undefined, 0), errMessage);
|
|
assert.throws(doSetInterval(null, 0), errMessage);
|
|
assert.throws(doSetInterval(false, 0), errMessage);
|
|
|
|
|
|
function doSetImmediate(callback, after) {
|
|
return function() {
|
|
setImmediate(callback, after);
|
|
};
|
|
}
|
|
|
|
assert.throws(doSetImmediate('foo'), errMessage);
|
|
assert.throws(doSetImmediate({ foo: 'bar' }), errMessage);
|
|
assert.throws(doSetImmediate(), errMessage);
|
|
assert.throws(doSetImmediate(undefined, 0), errMessage);
|
|
assert.throws(doSetImmediate(null, 0), errMessage);
|
|
assert.throws(doSetImmediate(false, 0), errMessage);
|