mirror of
https://github.com/nodejs/node.git
synced 2025-05-05 08:53:12 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
105 lines
2.3 KiB
JavaScript
105 lines
2.3 KiB
JavaScript
// Flags: --expose-internals
|
|
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
|
|
const { strictEqual, throws } = require('assert');
|
|
const { setUnrefTimeout } = require('internal/timers');
|
|
const { inspect } = require('util');
|
|
|
|
// Schedule the unrefed cases first so that the later case keeps the event loop
|
|
// active.
|
|
|
|
// Every case in this test relies on implicit sorting within either Node's or
|
|
// libuv's timers storage data structures.
|
|
|
|
// unref()'d timer
|
|
{
|
|
let called = false;
|
|
const timer = setTimeout(common.mustCall(() => {
|
|
called = true;
|
|
}), 1);
|
|
timer.unref();
|
|
|
|
// This relies on implicit timers handle sorting within libuv.
|
|
|
|
setTimeout(common.mustCall(() => {
|
|
strictEqual(called, false, 'unref()\'d timer returned before check');
|
|
}), 1);
|
|
|
|
strictEqual(timer.refresh(), timer);
|
|
}
|
|
|
|
// Should throw with non-functions
|
|
{
|
|
[null, true, false, 0, 1, NaN, '', 'foo', {}, Symbol()].forEach((cb) => {
|
|
throws(
|
|
() => setUnrefTimeout(cb),
|
|
{
|
|
code: 'ERR_INVALID_CALLBACK',
|
|
message: `Callback must be a function. Received ${inspect(cb)}`
|
|
}
|
|
);
|
|
});
|
|
}
|
|
|
|
// unref pooled timer
|
|
{
|
|
let called = false;
|
|
const timer = setUnrefTimeout(common.mustCall(() => {
|
|
called = true;
|
|
}), 1);
|
|
|
|
setUnrefTimeout(common.mustCall(() => {
|
|
strictEqual(called, false, 'unref pooled timer returned before check');
|
|
}), 1);
|
|
|
|
strictEqual(timer.refresh(), timer);
|
|
}
|
|
|
|
// regular timer
|
|
{
|
|
let called = false;
|
|
const timer = setTimeout(common.mustCall(() => {
|
|
called = true;
|
|
}), 1);
|
|
|
|
setTimeout(common.mustCall(() => {
|
|
strictEqual(called, false, 'pooled timer returned before check');
|
|
}), 1);
|
|
|
|
strictEqual(timer.refresh(), timer);
|
|
}
|
|
|
|
// regular timer
|
|
{
|
|
let called = false;
|
|
const timer = setTimeout(common.mustCall(() => {
|
|
if (!called) {
|
|
called = true;
|
|
process.nextTick(common.mustCall(() => {
|
|
timer.refresh();
|
|
strictEqual(timer.hasRef(), true);
|
|
}));
|
|
}
|
|
}, 2), 1);
|
|
}
|
|
|
|
// interval
|
|
{
|
|
let called = 0;
|
|
const timer = setInterval(common.mustCall(() => {
|
|
called += 1;
|
|
if (called === 2) {
|
|
clearInterval(timer);
|
|
}
|
|
}, 2), 1);
|
|
|
|
setTimeout(common.mustCall(() => {
|
|
strictEqual(called, 0, 'pooled timer returned before check');
|
|
}), 1);
|
|
|
|
strictEqual(timer.refresh(), timer);
|
|
}
|