mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 11:12:55 +00:00
311e12b962
Previously destroy could be called multiple times causing inconsistent and hard to predict behavior. Furthermore, since the stream _destroy implementation can only be called once, the behavior of applying destroy multiple times becomes unclear. This changes so that only the first destroy() call is executed and any subsequent calls are noops. PR-URL: https://github.com/nodejs/node/pull/29197 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
49 lines
984 B
JavaScript
49 lines
984 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
|
|
const { Writable } = require('stream');
|
|
|
|
{
|
|
const w = new Writable({
|
|
write() {}
|
|
});
|
|
assert.strictEqual(w.writable, true);
|
|
w.destroy();
|
|
assert.strictEqual(w.writable, false);
|
|
}
|
|
|
|
{
|
|
const w = new Writable({
|
|
write: common.mustCall((chunk, encoding, callback) => {
|
|
callback(new Error());
|
|
})
|
|
});
|
|
assert.strictEqual(w.writable, true);
|
|
w.write('asd');
|
|
assert.strictEqual(w.writable, false);
|
|
w.on('error', common.mustCall());
|
|
}
|
|
|
|
{
|
|
const w = new Writable({
|
|
write: common.mustCall((chunk, encoding, callback) => {
|
|
process.nextTick(() => {
|
|
callback(new Error());
|
|
assert.strictEqual(w.writable, false);
|
|
});
|
|
})
|
|
});
|
|
w.write('asd');
|
|
w.on('error', common.mustCall());
|
|
}
|
|
|
|
{
|
|
const w = new Writable({
|
|
write: common.mustNotCall()
|
|
});
|
|
assert.strictEqual(w.writable, true);
|
|
w.end();
|
|
assert.strictEqual(w.writable, false);
|
|
}
|