node/test/parallel/test-stream-writable-end-cb-error.js
Robert Nagy a4fce32eab stream: fix .end() error propagation
PR-URL: https://github.com/nodejs/node/pull/36817
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2021-01-11 17:57:05 +01:00

84 lines
2.4 KiB
JavaScript

'use strict';
const common = require('../common');
const assert = require('assert');
const stream = require('stream');
{
// Invoke end callback on failure.
const writable = new stream.Writable();
writable._write = (chunk, encoding, cb) => {
process.nextTick(cb, new Error('kaboom'));
};
writable.on('error', common.mustCall((err) => {
assert.strictEqual(err.message, 'kaboom');
}));
writable.write('asd');
writable.end(common.mustCall((err) => {
assert.strictEqual(err.code, 'ERR_STREAM_DESTROYED');
}));
writable.end(common.mustCall((err) => {
assert.strictEqual(err.code, 'ERR_STREAM_DESTROYED');
}));
}
{
// Don't invoke end callback twice
const writable = new stream.Writable();
writable._write = (chunk, encoding, cb) => {
process.nextTick(cb);
};
let called = false;
writable.end('asd', common.mustCall((err) => {
called = true;
assert.strictEqual(err, undefined);
}));
writable.on('error', common.mustCall((err) => {
assert.strictEqual(err.message, 'kaboom');
}));
writable.on('finish', common.mustCall(() => {
assert.strictEqual(called, true);
writable.emit('error', new Error('kaboom'));
}));
}
{
const w = new stream.Writable({
write(chunk, encoding, callback) {
setImmediate(callback);
},
finish(callback) {
setImmediate(callback);
}
});
w.end('testing ended state', common.mustCall((err) => {
// This errors since .destroy(err), which is invoked by errors
// in same tick below, will error all pending callbacks.
// Does this make sense? Not sure.
assert.strictEqual(err.code, 'ERR_STREAM_DESTROYED');
}));
assert.strictEqual(w.destroyed, false);
assert.strictEqual(w.writableEnded, true);
w.end(common.mustCall((err) => {
// This errors since .destroy(err), which is invoked by errors
// in same tick below, will error all pending callbacks.
// Does this make sense? Not sure.
assert.strictEqual(err.code, 'ERR_STREAM_DESTROYED');
}));
assert.strictEqual(w.destroyed, false);
assert.strictEqual(w.writableEnded, true);
w.end('end', common.mustCall((err) => {
assert.strictEqual(err.code, 'ERR_STREAM_WRITE_AFTER_END');
}));
assert.strictEqual(w.destroyed, true);
w.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ERR_STREAM_WRITE_AFTER_END');
}));
w.on('finish', common.mustNotCall());
}