mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 09:52:21 +00:00
83ec33b933
HTTP/2 streams call `.end()` on themselves from their `.destroy()` method, which might be queued (e.g. due to network congestion) and not processed before the stream itself is destroyed. In that case, the `_writableState.ended` property could be set before the stream emits its `'close'` event, and never actually emits the `'finished'` event, confusing the end-of-stream implementation so that it wouldn’t call its callback. This can be fixed by watching for the end events themselves using the existing `'finish'` and `'end'` listeners rather than relying on the `.ended` properties of the `_...State` objects. These properties still need to be checked to know whether stream closure was premature – My understanding is that ideally, streams should not emit `'close'` before `'end'` and/or `'finished'`, so this might be another bug, but changing this would require modifying tests and almost certainly be a breaking change. Fixes: https://github.com/nodejs/node/issues/24456 PR-URL: https://github.com/nodejs/node/pull/24926 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
40 lines
1.1 KiB
JavaScript
40 lines
1.1 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const { Readable, Duplex, pipeline } = require('stream');
|
|
|
|
// Test that the callback for pipeline() is called even when the ._destroy()
|
|
// method of the stream places an .end() request to itself that does not
|
|
// get processed before the destruction of the stream (i.e. the 'close' event).
|
|
// Refs: https://github.com/nodejs/node/issues/24456
|
|
|
|
const readable = new Readable({
|
|
read: common.mustCall(() => {})
|
|
});
|
|
|
|
const duplex = new Duplex({
|
|
write(chunk, enc, cb) {
|
|
// Simulate messages queueing up.
|
|
},
|
|
read() {},
|
|
destroy(err, cb) {
|
|
// Call end() from inside the destroy() method, like HTTP/2 streams
|
|
// do at the time of writing.
|
|
this.end();
|
|
cb(err);
|
|
}
|
|
});
|
|
|
|
duplex.on('finished', common.mustNotCall());
|
|
|
|
pipeline(readable, duplex, common.mustCall((err) => {
|
|
assert.strictEqual(err.code, 'ERR_STREAM_PREMATURE_CLOSE');
|
|
}));
|
|
|
|
// Write one chunk of data, and destroy the stream later.
|
|
// That should trigger the pipeline destruction.
|
|
readable.push('foo');
|
|
setImmediate(() => {
|
|
readable.destroy();
|
|
});
|