mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 18:37:06 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
42 lines
1.4 KiB
JavaScript
42 lines
1.4 KiB
JavaScript
'use strict';
|
|
require('../common');
|
|
const assert = require('assert');
|
|
|
|
const qs = require('querystring');
|
|
|
|
assert.deepStrictEqual(qs.escape(5), '5');
|
|
assert.deepStrictEqual(qs.escape('test'), 'test');
|
|
assert.deepStrictEqual(qs.escape({}), '%5Bobject%20Object%5D');
|
|
assert.deepStrictEqual(qs.escape([5, 10]), '5%2C10');
|
|
assert.deepStrictEqual(qs.escape('Ŋōđĕ'), '%C5%8A%C5%8D%C4%91%C4%95');
|
|
assert.deepStrictEqual(qs.escape('testŊōđĕ'), 'test%C5%8A%C5%8D%C4%91%C4%95');
|
|
assert.deepStrictEqual(qs.escape(`${String.fromCharCode(0xD800 + 1)}test`),
|
|
'%F0%90%91%B4est');
|
|
|
|
assert.throws(
|
|
() => qs.escape(String.fromCharCode(0xD800 + 1)),
|
|
{
|
|
code: 'ERR_INVALID_URI',
|
|
name: 'URIError',
|
|
message: 'URI malformed'
|
|
}
|
|
);
|
|
|
|
// Using toString for objects
|
|
assert.strictEqual(
|
|
qs.escape({ test: 5, toString: () => 'test', valueOf: () => 10 }),
|
|
'test'
|
|
);
|
|
|
|
// `toString` is not callable, must throw an error.
|
|
// Error message will vary between different JavaScript engines, so only check
|
|
// that it is a `TypeError`.
|
|
assert.throws(() => qs.escape({ toString: 5 }), TypeError);
|
|
|
|
// Should use valueOf instead of non-callable toString.
|
|
assert.strictEqual(qs.escape({ toString: 5, valueOf: () => 'test' }), 'test');
|
|
|
|
// Error message will vary between different JavaScript engines, so only check
|
|
// that it is a `TypeError`.
|
|
assert.throws(() => qs.escape(Symbol('test')), TypeError);
|