mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 11:12:55 +00:00
f3eb224c83
* Update the user timing implementation to conform to User Timing Level 3. * Reimplement user timing and timerify with pure JavaScript implementations * Simplify the C++ implementation for gc and http2 perf * Runtime deprecate additional perf entry properties in favor of the standard detail argument * Disable the `buffered` option on PerformanceObserver, all entries are queued and dispatched on setImmediate. Only entries with active observers are buffered. * This does remove the user timing and timerify trace events. Because the trace_events are still considered experimental, those can be removed without a deprecation cycle. They are removed to improve performance and reduce complexity. Old: `perf_hooks/usertiming.js n=100000: 92,378.01249733355` New: perf_hooks/usertiming.js n=100000: 270,393.5280638482` PR-URL: https://github.com/nodejs/node/pull/37136 Refs: https://github.com/nodejs/diagnostics/issues/464 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
79 lines
2.0 KiB
JavaScript
79 lines
2.0 KiB
JavaScript
// Flags: --expose-internals --no-warnings
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const { inspect } = require('util');
|
|
const { internalBinding } = require('internal/test/binding');
|
|
const {
|
|
observerCounts: counts
|
|
} = internalBinding('performance');
|
|
const {
|
|
performance,
|
|
PerformanceObserver,
|
|
constants
|
|
} = require('perf_hooks');
|
|
|
|
const {
|
|
NODE_PERFORMANCE_ENTRY_TYPE_GC,
|
|
NODE_PERFORMANCE_ENTRY_TYPE_HTTP2,
|
|
} = constants;
|
|
|
|
assert.strictEqual(counts[NODE_PERFORMANCE_ENTRY_TYPE_GC], 0);
|
|
assert.strictEqual(counts[NODE_PERFORMANCE_ENTRY_TYPE_HTTP2], 0);
|
|
|
|
{
|
|
[1, null, undefined, {}, [], Infinity].forEach((i) => {
|
|
assert.throws(
|
|
() => new PerformanceObserver(i),
|
|
{
|
|
code: 'ERR_INVALID_CALLBACK',
|
|
name: 'TypeError',
|
|
message: `Callback must be a function. Received ${inspect(i)}`
|
|
}
|
|
);
|
|
});
|
|
const observer = new PerformanceObserver(common.mustNotCall());
|
|
|
|
[1, 'test'].forEach((input) => {
|
|
assert.throws(
|
|
() => observer.observe(input),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "options" argument must be of type object.' +
|
|
common.invalidArgTypeHelper(input)
|
|
});
|
|
});
|
|
|
|
[1, null, {}, Infinity].forEach((i) => {
|
|
assert.throws(() => observer.observe({ entryTypes: i }),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError'
|
|
});
|
|
});
|
|
|
|
const obs = new PerformanceObserver(common.mustNotCall());
|
|
obs.observe({ entryTypes: ['mark', 'mark'] });
|
|
obs.disconnect();
|
|
performance.mark('42');
|
|
}
|
|
|
|
// Test Non-Buffered
|
|
{
|
|
const observer =
|
|
new PerformanceObserver(common.mustCall(callback));
|
|
|
|
function callback(list, obs) {
|
|
assert.strictEqual(obs, observer);
|
|
const entries = list.getEntries();
|
|
assert.strictEqual(entries.length, 3);
|
|
observer.disconnect();
|
|
}
|
|
observer.observe({ entryTypes: ['mark', 'node'] });
|
|
performance.mark('test1');
|
|
performance.mark('test2');
|
|
performance.mark('test3');
|
|
}
|