mirror of
https://github.com/nodejs/node.git
synced 2025-05-04 15:02:25 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
49 lines
998 B
JavaScript
49 lines
998 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const net = require('net');
|
|
|
|
['foobar', 1, {}, []].forEach((input) => connectThrows(input));
|
|
|
|
// Using port 0 as lookup is emitted before connecting.
|
|
function connectThrows(input) {
|
|
const opts = {
|
|
host: 'localhost',
|
|
port: 0,
|
|
lookup: input
|
|
};
|
|
|
|
assert.throws(() => {
|
|
net.connect(opts);
|
|
}, {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError'
|
|
});
|
|
}
|
|
|
|
connectDoesNotThrow(() => {});
|
|
|
|
function connectDoesNotThrow(input) {
|
|
const opts = {
|
|
host: 'localhost',
|
|
port: 0,
|
|
lookup: input
|
|
};
|
|
|
|
return net.connect(opts);
|
|
}
|
|
|
|
{
|
|
// Verify that an error is emitted when an invalid address family is returned.
|
|
const s = connectDoesNotThrow((host, options, cb) => {
|
|
cb(null, '127.0.0.1', 100);
|
|
});
|
|
|
|
s.on('error', common.expectsError({
|
|
code: 'ERR_INVALID_ADDRESS_FAMILY',
|
|
host: 'localhost',
|
|
port: 0,
|
|
message: 'Invalid address family: 100 localhost:0'
|
|
}));
|
|
}
|