mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 11:12:55 +00:00
c66e6471e7
This will be a start to generalize all argument validation errors. As currently we throw ARG/OPT, OUT_OF_RANGE, and other more specific errors. The OPT errors didn't bring much to the errors as it's just another variant of ARG error which is sometimes more confusing (some of our code used OPT errors to denote just argument validation errors presumably because of similarity of OPT to 'option' and not 'options-object') and they don't specify the name of the options object where the invalid value is located. Much better approach would be to just specify path to the invalid value in the name of the value as it is done in this PR (i.e. 'options.format', 'options.publicKey.type' etc) Also since this decreases a variety of errors we have it'd be easier to reuse validation code across the codebase. Refs: https://github.com/nodejs/node/pull/31251 Refs: https://github.com/nodejs/node/pull/34070#discussion_r467251009 Signed-off-by: Denys Otrishko <shishugi@gmail.com> PR-URL: https://github.com/nodejs/node/pull/34682 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
54 lines
1.2 KiB
JavaScript
54 lines
1.2 KiB
JavaScript
// Flags: --expose-internals
|
|
'use strict';
|
|
|
|
require('../common');
|
|
const assert = require('assert');
|
|
const fs = require('internal/fs/utils');
|
|
|
|
// Valid encodings and no args should not throw.
|
|
fs.assertEncoding();
|
|
fs.assertEncoding('utf8');
|
|
|
|
assert.throws(
|
|
() => fs.assertEncoding('foo'),
|
|
{ code: 'ERR_INVALID_ARG_VALUE', name: 'TypeError' }
|
|
);
|
|
|
|
// Test junction symlinks
|
|
{
|
|
const pathString = 'c:\\test1';
|
|
const linkPathString = '\\test2';
|
|
|
|
const preprocessSymlinkDestination = fs.preprocessSymlinkDestination(
|
|
pathString,
|
|
'junction',
|
|
linkPathString
|
|
);
|
|
|
|
if (process.platform === 'win32') {
|
|
assert.strictEqual(/^\\\\\?\\/.test(preprocessSymlinkDestination), true);
|
|
} else {
|
|
assert.strictEqual(preprocessSymlinkDestination, pathString);
|
|
}
|
|
}
|
|
|
|
// Test none junction symlinks
|
|
{
|
|
const pathString = 'c:\\test1';
|
|
const linkPathString = '\\test2';
|
|
|
|
const preprocessSymlinkDestination = fs.preprocessSymlinkDestination(
|
|
pathString,
|
|
undefined,
|
|
linkPathString
|
|
);
|
|
|
|
if (process.platform === 'win32') {
|
|
// There should not be any forward slashes
|
|
assert.strictEqual(
|
|
/\//.test(preprocessSymlinkDestination), false);
|
|
} else {
|
|
assert.strictEqual(preprocessSymlinkDestination, pathString);
|
|
}
|
|
}
|