mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 15:17:17 +00:00
311e12b962
Previously destroy could be called multiple times causing inconsistent and hard to predict behavior. Furthermore, since the stream _destroy implementation can only be called once, the behavior of applying destroy multiple times becomes unclear. This changes so that only the first destroy() call is executed and any subsequent calls are noops. PR-URL: https://github.com/nodejs/node/pull/29197 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
54 lines
1.7 KiB
JavaScript
54 lines
1.7 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const h2 = require('http2');
|
|
|
|
const server = h2.createServer();
|
|
|
|
server.on('stream', common.mustCall((stream) => {
|
|
assert(stream.session);
|
|
stream.session.destroy();
|
|
assert.strictEqual(stream.session, undefined);
|
|
|
|
// Test that stream.state getter returns an empty object
|
|
// when the stream session has been destroyed
|
|
assert.deepStrictEqual({}, stream.state);
|
|
|
|
// Test that ERR_HTTP2_INVALID_STREAM is thrown while calling
|
|
// stream operations after the stream session has been destroyed
|
|
const invalidStreamError = {
|
|
name: 'Error',
|
|
code: 'ERR_HTTP2_INVALID_STREAM',
|
|
message: 'The stream has been destroyed'
|
|
};
|
|
assert.throws(() => stream.additionalHeaders(), invalidStreamError);
|
|
assert.throws(() => stream.priority(), invalidStreamError);
|
|
assert.throws(() => stream.respond(), invalidStreamError);
|
|
assert.throws(
|
|
() => stream.pushStream({}, common.mustNotCall()),
|
|
{
|
|
code: 'ERR_HTTP2_PUSH_DISABLED',
|
|
name: 'Error'
|
|
}
|
|
);
|
|
// When session is detroyed all streams are destroyed and no further
|
|
// error should be emitted.
|
|
stream.on('error', common.mustNotCall());
|
|
assert.strictEqual(stream.write('data', common.expectsError({
|
|
name: 'Error',
|
|
code: 'ERR_STREAM_WRITE_AFTER_END',
|
|
message: 'write after end'
|
|
})), false);
|
|
}));
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const client = h2.connect(`http://localhost:${server.address().port}`);
|
|
const req = client.request();
|
|
req.resume();
|
|
req.on('end', common.mustCall());
|
|
req.on('close', common.mustCall(() => server.close(common.mustCall())));
|
|
}));
|