mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 13:28:42 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
43 lines
1016 B
JavaScript
43 lines
1016 B
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
const assert = require('assert');
|
|
const http2 = require('http2');
|
|
const { inspect } = require('util');
|
|
|
|
// Verify that setTimeout callback verifications work correctly
|
|
const verifyCallbacks = (server) => {
|
|
const testTimeout = 10;
|
|
|
|
[true, 1, {}, [], null, 'test'].forEach((notFunction) => {
|
|
assert.throws(
|
|
() => server.setTimeout(testTimeout, notFunction),
|
|
{
|
|
name: 'TypeError',
|
|
code: 'ERR_INVALID_CALLBACK',
|
|
message: 'Callback must be a function. ' +
|
|
`Received ${inspect(notFunction)}`
|
|
}
|
|
);
|
|
});
|
|
|
|
// No callback
|
|
const returnedVal = server.setTimeout(testTimeout);
|
|
assert.strictEqual(returnedVal.timeout, testTimeout);
|
|
};
|
|
|
|
// Test with server
|
|
{
|
|
const server = http2.createServer();
|
|
verifyCallbacks(server);
|
|
}
|
|
|
|
// Test with secure server
|
|
{
|
|
const secureServer = http2.createSecureServer({});
|
|
verifyCallbacks(secureServer);
|
|
}
|