mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 13:28:42 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
58 lines
1.5 KiB
JavaScript
58 lines
1.5 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const http2 = require('http2');
|
|
|
|
// Check that pushStream handles being passed wrong arguments
|
|
// in the expected manner
|
|
|
|
const server = http2.createServer();
|
|
server.on('stream', common.mustCall((stream, headers) => {
|
|
const port = server.address().port;
|
|
|
|
// Must receive a callback (function)
|
|
assert.throws(
|
|
() => stream.pushStream({
|
|
':scheme': 'http',
|
|
':path': '/foobar',
|
|
':authority': `localhost:${port}`,
|
|
}, {}, 'callback'),
|
|
{
|
|
code: 'ERR_INVALID_CALLBACK',
|
|
message: "Callback must be a function. Received 'callback'"
|
|
}
|
|
);
|
|
|
|
// Must validate headers
|
|
assert.throws(
|
|
() => stream.pushStream({ 'connection': 'test' }, {}, () => {}),
|
|
{
|
|
code: 'ERR_HTTP2_INVALID_CONNECTION_HEADERS',
|
|
name: 'TypeError',
|
|
message: 'HTTP/1 Connection specific headers are forbidden: "connection"'
|
|
}
|
|
);
|
|
|
|
stream.end('test');
|
|
}));
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const port = server.address().port;
|
|
const headers = { ':path': '/' };
|
|
const client = http2.connect(`http://localhost:${port}`);
|
|
const req = client.request(headers);
|
|
req.setEncoding('utf8');
|
|
|
|
let data = '';
|
|
req.on('data', common.mustCall((d) => data += d));
|
|
req.on('end', common.mustCall(() => {
|
|
assert.strictEqual(data, 'test');
|
|
server.close();
|
|
client.close();
|
|
}));
|
|
req.end();
|
|
}));
|