mirror of
https://github.com/nodejs/node.git
synced 2025-05-05 18:57:34 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
66 lines
1.7 KiB
JavaScript
66 lines
1.7 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const http2 = require('http2');
|
|
const Countdown = require('../common/countdown');
|
|
|
|
const server = http2.createServer();
|
|
|
|
server.on('stream', common.mustCall((stream) => {
|
|
stream.respond();
|
|
stream.end();
|
|
}));
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const client = http2.connect(`http://localhost:${server.address().port}`);
|
|
|
|
const countdown = new Countdown(2, () => {
|
|
server.close();
|
|
client.close();
|
|
});
|
|
|
|
// Request 1 will fail because there are two content-length header values
|
|
assert.throws(
|
|
() => {
|
|
client.request({
|
|
':method': 'POST',
|
|
'content-length': 1,
|
|
'Content-Length': 2
|
|
});
|
|
}, {
|
|
code: 'ERR_HTTP2_HEADER_SINGLE_VALUE',
|
|
name: 'TypeError',
|
|
message: 'Header field "content-length" must only have a single value'
|
|
}
|
|
);
|
|
|
|
{
|
|
// Request 2 will succeed
|
|
const req = client.request({
|
|
':method': 'POST',
|
|
'content-length': 1
|
|
});
|
|
req.resume();
|
|
req.on('end', common.mustCall());
|
|
req.on('close', common.mustCall(() => countdown.dec()));
|
|
req.end('a');
|
|
}
|
|
|
|
{
|
|
// Request 3 will fail because nghttp2 does not allow the content-length
|
|
// header to be set for non-payload bearing requests...
|
|
const req = client.request({ 'content-length': 1 });
|
|
req.resume();
|
|
req.on('end', common.mustCall());
|
|
req.on('close', common.mustCall(() => countdown.dec()));
|
|
req.on('error', common.expectsError({
|
|
code: 'ERR_HTTP2_STREAM_ERROR',
|
|
name: 'Error',
|
|
message: 'Stream closed with error code NGHTTP2_PROTOCOL_ERROR'
|
|
}));
|
|
}
|
|
}));
|