node/test/parallel/test-http-invalidheaderfield.js
Ruben Bridgewater 644fdd60d4
test: minor refactoring
Add punctuation and comments about code that should not throw.
Also remove a obsolete test and refactor some tests.

PR-URL: https://github.com/nodejs/node/pull/18669
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2018-02-16 16:54:07 +01:00

53 lines
1.0 KiB
JavaScript

'use strict';
const common = require('../common');
const assert = require('assert');
const EventEmitter = require('events');
const http = require('http');
const ee = new EventEmitter();
let count = 3;
const server = http.createServer(function(req, res) {
res.setHeader('testing_123', 123);
assert.throws(function() {
res.setHeader('testing 123', 123);
}, TypeError);
res.end('');
});
server.listen(0, function() {
http.get({ port: this.address().port }, function() {
ee.emit('done');
});
assert.throws(
function() {
const options = {
port: server.address().port,
headers: { 'testing 123': 123 }
};
http.get(options, common.mustNotCall());
},
function(err) {
ee.emit('done');
if (err instanceof TypeError) return true;
}
);
// Should not throw.
const options = {
port: server.address().port,
headers: { 'testing_123': 123 }
};
http.get(options, function() {
ee.emit('done');
});
});
ee.on('done', function() {
if (--count === 0) {
server.close();
}
});