mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 09:52:21 +00:00
fae0320e7e
If `fs.read()` is called without specifying the `position` option, data will be read from the current file position. There is another concurrent `fs.read()` call before the test for no options object which might invalidate the test expectations. Run the test for no options object first. PR-URL: https://github.com/nodejs/node/pull/37991 Fixes: https://github.com/nodejs/node/issues/37946 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
37 lines
1.2 KiB
JavaScript
37 lines
1.2 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const fixtures = require('../common/fixtures');
|
|
const fs = require('fs');
|
|
const assert = require('assert');
|
|
const filepath = fixtures.path('x.txt');
|
|
const fd = fs.openSync(filepath, 'r');
|
|
|
|
const expected = Buffer.from('xyz\n');
|
|
const defaultBufferAsync = Buffer.alloc(16384);
|
|
const bufferAsOption = Buffer.allocUnsafe(expected.length);
|
|
|
|
// Test not passing in any options object
|
|
fs.read(fd, common.mustCall((err, bytesRead, buffer) => {
|
|
assert.strictEqual(bytesRead, expected.length);
|
|
assert.deepStrictEqual(defaultBufferAsync.length, buffer.length);
|
|
}));
|
|
|
|
// Test passing in an empty options object
|
|
fs.read(fd, { position: 0 }, common.mustCall((err, bytesRead, buffer) => {
|
|
assert.strictEqual(bytesRead, expected.length);
|
|
assert.deepStrictEqual(defaultBufferAsync.length, buffer.length);
|
|
}));
|
|
|
|
// Test passing in options
|
|
fs.read(fd, {
|
|
buffer: bufferAsOption,
|
|
offset: 0,
|
|
length: bufferAsOption.length,
|
|
position: 0
|
|
},
|
|
common.mustCall((err, bytesRead, buffer) => {
|
|
assert.strictEqual(bytesRead, expected.length);
|
|
assert.deepStrictEqual(bufferAsOption.length, buffer.length);
|
|
}));
|