node/test/parallel/test-fs-lchmod.js
James M Snell da217d0773
fs: fix flag and mode validation
The `flag` and `mode` options were not being validated correctly.

Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: https://github.com/nodejs/node/issues/37430

PR-URL: https://github.com/nodejs/node/pull/37480
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2021-03-01 09:47:56 -08:00

67 lines
1.7 KiB
JavaScript

'use strict';
const common = require('../common');
const assert = require('assert');
const fs = require('fs');
const { promises } = fs;
const f = __filename;
// This test ensures that input for lchmod is valid, testing for valid
// inputs for path, mode and callback
if (!common.isOSX) {
common.skip('lchmod is only available on macOS');
}
// Check callback
assert.throws(() => fs.lchmod(f), { code: 'ERR_INVALID_CALLBACK' });
assert.throws(() => fs.lchmod(), { code: 'ERR_INVALID_CALLBACK' });
assert.throws(() => fs.lchmod(f, {}), { code: 'ERR_INVALID_CALLBACK' });
// Check path
[false, 1, {}, [], null, undefined].forEach((i) => {
assert.throws(
() => fs.lchmod(i, 0o777, common.mustNotCall()),
{
code: 'ERR_INVALID_ARG_TYPE',
name: 'TypeError'
}
);
assert.throws(
() => fs.lchmodSync(i),
{
code: 'ERR_INVALID_ARG_TYPE',
name: 'TypeError'
}
);
});
// Check mode
[false, null, {}, []].forEach((input) => {
const errObj = {
code: 'ERR_INVALID_ARG_TYPE',
};
assert.rejects(promises.lchmod(f, input, () => {}), errObj);
assert.throws(() => fs.lchmodSync(f, input), errObj);
});
assert.throws(() => fs.lchmod(f, '123x', common.mustNotCall()), {
code: 'ERR_INVALID_ARG_VALUE'
});
assert.throws(() => fs.lchmodSync(f, '123x'), {
code: 'ERR_INVALID_ARG_VALUE'
});
[-1, 2 ** 32].forEach((input) => {
const errObj = {
code: 'ERR_OUT_OF_RANGE',
name: 'RangeError',
message: 'The value of "mode" is out of range. It must be >= 0 && <= ' +
`4294967295. Received ${input}`
};
assert.rejects(promises.lchmod(f, input, () => {}), errObj);
assert.throws(() => fs.lchmodSync(f, input), errObj);
});