mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 09:52:26 +00:00

Make changes so that tests will pass when the comma-dangle settings applied to the rest of the code base are also applied to tests. PR-URL: https://github.com/nodejs/node/pull/37930 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
53 lines
1.4 KiB
JavaScript
53 lines
1.4 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
common.skipIfEslintMissing();
|
|
|
|
const RuleTester = require('../../tools/node_modules/eslint').RuleTester;
|
|
const rule = require('../../tools/eslint-rules/prefer-common-mustsucceed');
|
|
|
|
const msg1 = 'Please use common.mustSucceed instead of ' +
|
|
'common.mustCall(assert.ifError).';
|
|
const msg2 = 'Please use common.mustSucceed instead of ' +
|
|
'common.mustCall with assert.ifError.';
|
|
|
|
new RuleTester({
|
|
parserOptions: { ecmaVersion: 2015 }
|
|
}).run('prefer-common-mustsucceed', rule, {
|
|
valid: [
|
|
'foo((err) => assert.ifError(err))',
|
|
'foo(function(err) { assert.ifError(err) })',
|
|
'foo(assert.ifError)',
|
|
'common.mustCall((err) => err)',
|
|
],
|
|
invalid: [
|
|
{
|
|
code: 'common.mustCall(assert.ifError)',
|
|
errors: [{ message: msg1 }]
|
|
},
|
|
{
|
|
code: 'common.mustCall((err) => assert.ifError(err))',
|
|
errors: [{ message: msg2 }]
|
|
},
|
|
{
|
|
code: 'common.mustCall((e) => assert.ifError(e))',
|
|
errors: [{ message: msg2 }]
|
|
},
|
|
{
|
|
code: 'common.mustCall(function(e) { assert.ifError(e); })',
|
|
errors: [{ message: msg2 }]
|
|
},
|
|
{
|
|
code: 'common.mustCall(function(e) { return assert.ifError(e); })',
|
|
errors: [{ message: msg2 }]
|
|
},
|
|
{
|
|
code: 'common.mustCall(function(e) {{ assert.ifError(e); }})',
|
|
errors: [{ message: msg2 }]
|
|
},
|
|
]
|
|
});
|