mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 15:17:17 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
29 lines
728 B
JavaScript
29 lines
728 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
|
|
(function foobar() {
|
|
require('domain');
|
|
})();
|
|
|
|
assert.throws(
|
|
() => process.setUncaughtExceptionCaptureCallback(common.mustNotCall()),
|
|
(err) => {
|
|
common.expectsError(
|
|
{
|
|
code: 'ERR_DOMAIN_CANNOT_SET_UNCAUGHT_EXCEPTION_CAPTURE',
|
|
name: 'Error',
|
|
message: /^The `domain` module is in use, which is mutually/
|
|
}
|
|
)(err);
|
|
|
|
assert(err.stack.includes('-'.repeat(40)),
|
|
`expected ${err.stack} to contain dashes`);
|
|
|
|
const location = `at foobar (${__filename}:`;
|
|
assert(err.stack.includes(location),
|
|
`expected ${err.stack} to contain ${location}`);
|
|
return true;
|
|
}
|
|
);
|