mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 09:52:21 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
44 lines
1.1 KiB
JavaScript
44 lines
1.1 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
const assert = require('assert');
|
|
const crypto = require('crypto');
|
|
const invalidEngineName = 'xxx';
|
|
|
|
assert.throws(
|
|
() => crypto.setEngine(true),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "id" argument must be of type string. Received type boolean' +
|
|
' (true)'
|
|
});
|
|
|
|
assert.throws(
|
|
() => crypto.setEngine('/path/to/engine', 'notANumber'),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "flags" argument must be of type number. Received type' +
|
|
" string ('notANumber')"
|
|
});
|
|
|
|
assert.throws(
|
|
() => crypto.setEngine(invalidEngineName),
|
|
{
|
|
code: 'ERR_CRYPTO_ENGINE_UNKNOWN',
|
|
name: 'Error',
|
|
message: `Engine "${invalidEngineName}" was not found`
|
|
});
|
|
|
|
assert.throws(
|
|
() => crypto.setEngine(invalidEngineName, crypto.constants.ENGINE_METHOD_RSA),
|
|
{
|
|
code: 'ERR_CRYPTO_ENGINE_UNKNOWN',
|
|
name: 'Error',
|
|
message: `Engine "${invalidEngineName}" was not found`
|
|
});
|