mirror of
https://github.com/nodejs/node.git
synced 2025-05-04 16:42:07 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
95 lines
2.7 KiB
JavaScript
95 lines
2.7 KiB
JavaScript
'use strict';
|
|
|
|
require('../common');
|
|
const assert = require('assert');
|
|
|
|
const a = Buffer.from([1, 2, 3, 4, 5, 6, 7, 8, 9, 0]);
|
|
const b = Buffer.from([5, 6, 7, 8, 9, 0, 1, 2, 3, 4]);
|
|
|
|
assert.strictEqual(a.compare(b), -1);
|
|
|
|
// Equivalent to a.compare(b).
|
|
assert.strictEqual(a.compare(b, 0), -1);
|
|
assert.throws(() => a.compare(b, '0'), { code: 'ERR_INVALID_ARG_TYPE' });
|
|
assert.strictEqual(a.compare(b, undefined), -1);
|
|
|
|
// Equivalent to a.compare(b).
|
|
assert.strictEqual(a.compare(b, 0, undefined, 0), -1);
|
|
|
|
// Zero-length target, return 1
|
|
assert.strictEqual(a.compare(b, 0, 0, 0), 1);
|
|
assert.throws(
|
|
() => a.compare(b, 0, '0', '0'),
|
|
{ code: 'ERR_INVALID_ARG_TYPE' }
|
|
);
|
|
|
|
// Equivalent to Buffer.compare(a, b.slice(6, 10))
|
|
assert.strictEqual(a.compare(b, 6, 10), 1);
|
|
|
|
// Zero-length source, return -1
|
|
assert.strictEqual(a.compare(b, 6, 10, 0, 0), -1);
|
|
|
|
// Zero-length source and target, return 0
|
|
assert.strictEqual(a.compare(b, 0, 0, 0, 0), 0);
|
|
assert.strictEqual(a.compare(b, 1, 1, 2, 2), 0);
|
|
|
|
// Equivalent to Buffer.compare(a.slice(4), b.slice(0, 5))
|
|
assert.strictEqual(a.compare(b, 0, 5, 4), 1);
|
|
|
|
// Equivalent to Buffer.compare(a.slice(1), b.slice(5))
|
|
assert.strictEqual(a.compare(b, 5, undefined, 1), 1);
|
|
|
|
// Equivalent to Buffer.compare(a.slice(2), b.slice(2, 4))
|
|
assert.strictEqual(a.compare(b, 2, 4, 2), -1);
|
|
|
|
// Equivalent to Buffer.compare(a.slice(4), b.slice(0, 7))
|
|
assert.strictEqual(a.compare(b, 0, 7, 4), -1);
|
|
|
|
// Equivalent to Buffer.compare(a.slice(4, 6), b.slice(0, 7));
|
|
assert.strictEqual(a.compare(b, 0, 7, 4, 6), -1);
|
|
|
|
// Null is ambiguous.
|
|
assert.throws(
|
|
() => a.compare(b, 0, null),
|
|
{ code: 'ERR_INVALID_ARG_TYPE' }
|
|
);
|
|
|
|
// Values do not get coerced.
|
|
assert.throws(
|
|
() => a.compare(b, 0, { valueOf: () => 5 }),
|
|
{ code: 'ERR_INVALID_ARG_TYPE' }
|
|
);
|
|
|
|
// Infinity should not be coerced.
|
|
assert.throws(
|
|
() => a.compare(b, Infinity, -Infinity),
|
|
{ code: 'ERR_OUT_OF_RANGE' }
|
|
);
|
|
|
|
// Zero length target because default for targetEnd <= targetSource
|
|
assert.strictEqual(a.compare(b, 0xff), 1);
|
|
|
|
assert.throws(
|
|
() => a.compare(b, '0xff'),
|
|
{ code: 'ERR_INVALID_ARG_TYPE' }
|
|
);
|
|
assert.throws(
|
|
() => a.compare(b, 0, '0xff'),
|
|
{ code: 'ERR_INVALID_ARG_TYPE' }
|
|
);
|
|
|
|
const oor = { code: 'ERR_OUT_OF_RANGE' };
|
|
|
|
assert.throws(() => a.compare(b, 0, 100, 0), oor);
|
|
assert.throws(() => a.compare(b, 0, 1, 0, 100), oor);
|
|
assert.throws(() => a.compare(b, -1), oor);
|
|
assert.throws(() => a.compare(b, 0, Infinity), oor);
|
|
assert.throws(() => a.compare(b, 0, 1, -1), oor);
|
|
assert.throws(() => a.compare(b, -Infinity, Infinity), oor);
|
|
assert.throws(() => a.compare(), {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "target" argument must be an instance of ' +
|
|
'Buffer or Uint8Array. Received undefined'
|
|
});
|