mirror of
https://github.com/nodejs/node.git
synced 2025-05-06 12:54:43 +00:00
2c33819370
20285ad177 changed the format
of error messages throughout lib. However, the tests were not
updated to reflect these changes. This commit makes those
changes.
PR-URL: https://github.com/nodejs/node/pull/3727
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
116 lines
3.4 KiB
JavaScript
116 lines
3.4 KiB
JavaScript
'use strict';
|
|
require('../common');
|
|
var assert = require('assert');
|
|
var path = require('path');
|
|
|
|
var winPaths = [
|
|
'C:\\path\\dir\\index.html',
|
|
'C:\\another_path\\DIR\\1\\2\\33\\index',
|
|
'another_path\\DIR with spaces\\1\\2\\33\\index',
|
|
'\\foo\\C:',
|
|
'file',
|
|
'.\\file',
|
|
'',
|
|
|
|
// unc
|
|
'\\\\server\\share\\file_path',
|
|
'\\\\server two\\shared folder\\file path.zip',
|
|
'\\\\teela\\admin$\\system32',
|
|
'\\\\?\\UNC\\server\\share'
|
|
];
|
|
|
|
var winSpecialCaseFormatTests = [
|
|
[{dir: 'some\\dir'}, 'some\\dir\\'],
|
|
[{base: 'index.html'}, 'index.html'],
|
|
[{}, '']
|
|
];
|
|
|
|
var unixPaths = [
|
|
'/home/user/dir/file.txt',
|
|
'/home/user/a dir/another File.zip',
|
|
'/home/user/a dir//another&File.',
|
|
'/home/user/a$$$dir//another File.zip',
|
|
'user/dir/another File.zip',
|
|
'file',
|
|
'.\\file',
|
|
'./file',
|
|
'C:\\foo',
|
|
''
|
|
];
|
|
|
|
var unixSpecialCaseFormatTests = [
|
|
[{dir: 'some/dir'}, 'some/dir/'],
|
|
[{base: 'index.html'}, 'index.html'],
|
|
[{}, '']
|
|
];
|
|
|
|
var errors = [
|
|
{method: 'parse', input: [null],
|
|
message: /Path must be a string. Received null/},
|
|
{method: 'parse', input: [{}],
|
|
message: /Path must be a string. Received {}/},
|
|
{method: 'parse', input: [true],
|
|
message: /Path must be a string. Received true/},
|
|
{method: 'parse', input: [1],
|
|
message: /Path must be a string. Received 1/},
|
|
{method: 'parse', input: [],
|
|
message: /Path must be a string. Received undefined/},
|
|
{method: 'format', input: [null],
|
|
message: /Parameter "pathObject" must be an object, not/},
|
|
{method: 'format', input: [''],
|
|
message: /Parameter "pathObject" must be an object, not string/},
|
|
{method: 'format', input: [true],
|
|
message: /Parameter "pathObject" must be an object, not boolean/},
|
|
{method: 'format', input: [1],
|
|
message: /Parameter "pathObject" must be an object, not number/},
|
|
{method: 'format', input: [{root: true}],
|
|
message: /"pathObject\.root" must be a string or undefined, not boolean/},
|
|
{method: 'format', input: [{root: 12}],
|
|
message: /"pathObject\.root" must be a string or undefined, not number/},
|
|
];
|
|
|
|
checkParseFormat(path.win32, winPaths);
|
|
checkParseFormat(path.posix, unixPaths);
|
|
checkErrors(path.win32);
|
|
checkErrors(path.posix);
|
|
checkFormat(path.win32, winSpecialCaseFormatTests);
|
|
checkFormat(path.posix, unixSpecialCaseFormatTests);
|
|
|
|
function checkErrors(path) {
|
|
errors.forEach(function(errorCase) {
|
|
try {
|
|
path[errorCase.method].apply(path, errorCase.input);
|
|
} catch(err) {
|
|
assert.ok(err instanceof TypeError);
|
|
assert.ok(
|
|
errorCase.message.test(err.message),
|
|
'expected ' + errorCase.message + ' to match ' + err.message
|
|
);
|
|
return;
|
|
}
|
|
|
|
assert.fail(null, null, 'should have thrown');
|
|
});
|
|
}
|
|
|
|
function checkParseFormat(path, paths) {
|
|
paths.forEach(function(element) {
|
|
var output = path.parse(element);
|
|
assert.strictEqual(typeof output.root, 'string');
|
|
assert.strictEqual(typeof output.dir, 'string');
|
|
assert.strictEqual(typeof output.base, 'string');
|
|
assert.strictEqual(typeof output.ext, 'string');
|
|
assert.strictEqual(typeof output.name, 'string');
|
|
assert.strictEqual(path.format(output), element);
|
|
assert.strictEqual(output.dir, output.dir ? path.dirname(element) : '');
|
|
assert.strictEqual(output.base, path.basename(element));
|
|
assert.strictEqual(output.ext, path.extname(element));
|
|
});
|
|
}
|
|
|
|
function checkFormat(path, testCases) {
|
|
testCases.forEach(function(testCase) {
|
|
assert.strictEqual(path.format(testCase[0]), testCase[1]);
|
|
});
|
|
}
|