mirror of
https://github.com/nodejs/node.git
synced 2025-05-20 19:03:09 +00:00
2c23e31c31
- Moves THROW_AND_RETURN_IF_NOT_BUFFER and THROW_AND_RETURN_IF_NOT_STRING from node_crypto.cc to node_errors.h so it can be reused. - Move THROW_AND_RETURN_UNLESS_BUFFER in util.h to node_buffer.cc and call THROW_AND_RETURN_IF_NOT_BUFFER there. The only other reference to THROW_AND_RETURN_UNLESS_BUFFER in node_i18n.cc can be safely replaced by an assertion since the argument will be checked in JS land. - Migrate ERR_INVALID_ARG_TYPE errors in C++. We can move the checks to JS land if possible later without having to go semver-major. PR-URL: https://github.com/nodejs/node/pull/20121 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
118 lines
2.8 KiB
JavaScript
118 lines
2.8 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
const assert = require('assert');
|
|
const tls = require('tls');
|
|
|
|
common.expectsError(
|
|
() => tls.createSecureContext({ ciphers: 1 }),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: 'Ciphers must be a string'
|
|
});
|
|
|
|
common.expectsError(
|
|
() => tls.createServer({ ciphers: 1 }),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: 'Ciphers must be a string'
|
|
});
|
|
|
|
common.expectsError(
|
|
() => tls.createSecureContext({ key: 'dummykey', passphrase: 1 }),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: 'Pass phrase must be a string'
|
|
});
|
|
|
|
common.expectsError(
|
|
() => tls.createServer({ key: 'dummykey', passphrase: 1 }),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: 'Pass phrase must be a string'
|
|
});
|
|
|
|
common.expectsError(
|
|
() => tls.createServer({ ecdhCurve: 1 }),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: 'ECDH curve name must be a string'
|
|
});
|
|
|
|
common.expectsError(
|
|
() => tls.createServer({ handshakeTimeout: 'abcd' }),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: 'The "options.handshakeTimeout" property must ' +
|
|
'be of type number. Received type string'
|
|
}
|
|
);
|
|
|
|
common.expectsError(
|
|
() => tls.createServer({ sessionTimeout: 'abcd' }),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: 'Session timeout must be a 32-bit integer'
|
|
});
|
|
|
|
common.expectsError(
|
|
() => tls.createServer({ ticketKeys: 'abcd' }),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: 'Ticket keys must be a buffer'
|
|
});
|
|
|
|
assert.throws(() => tls.createServer({ ticketKeys: Buffer.alloc(0) }),
|
|
/TypeError: Ticket keys length must be 48 bytes/);
|
|
|
|
common.expectsError(
|
|
() => tls.createSecurePair({}),
|
|
{
|
|
code: 'ERR_ASSERTION',
|
|
message: 'context.context must be a NativeSecureContext'
|
|
}
|
|
);
|
|
|
|
{
|
|
const buffer = Buffer.from('abcd');
|
|
const out = {};
|
|
tls.convertALPNProtocols(buffer, out);
|
|
out.ALPNProtocols.write('efgh');
|
|
assert(buffer.equals(Buffer.from('abcd')));
|
|
assert(out.ALPNProtocols.equals(Buffer.from('efgh')));
|
|
}
|
|
|
|
{
|
|
const buffer = Buffer.from('abcd');
|
|
const out = {};
|
|
tls.convertNPNProtocols(buffer, out);
|
|
out.NPNProtocols.write('efgh');
|
|
assert(buffer.equals(Buffer.from('abcd')));
|
|
assert(out.NPNProtocols.equals(Buffer.from('efgh')));
|
|
}
|
|
|
|
{
|
|
const buffer = new Uint8Array(Buffer.from('abcd'));
|
|
const out = {};
|
|
tls.convertALPNProtocols(buffer, out);
|
|
assert(out.ALPNProtocols.equals(Buffer.from('abcd')));
|
|
}
|
|
|
|
{
|
|
const buffer = new Uint8Array(Buffer.from('abcd'));
|
|
const out = {};
|
|
tls.convertNPNProtocols(buffer, out);
|
|
assert(out.NPNProtocols.equals(Buffer.from('abcd')));
|
|
}
|