mirror of
https://github.com/nodejs/node.git
synced 2025-05-20 22:43:26 +00:00

Refactor Timers to behave more similarly to Immediates by having a single uv_timer_t handle which is stored on the Environment. No longer expose timers in a public binding and instead make it part of the internalBinding. PR-URL: https://github.com/nodejs/node/pull/20894 Fixes: https://github.com/nodejs/node/issues/10154 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
114 lines
3.8 KiB
JavaScript
114 lines
3.8 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const strictEqual = require('assert').strictEqual;
|
|
|
|
// child_process
|
|
{
|
|
const spawn = require('child_process').spawn;
|
|
const cmd = common.isWindows ? 'rundll32' : 'ls';
|
|
const cp = spawn(cmd);
|
|
strictEqual(Object.getPrototypeOf(cp._handle).hasOwnProperty('hasRef'),
|
|
true, 'process_wrap: hasRef() missing');
|
|
strictEqual(cp._handle.hasRef(),
|
|
true, 'process_wrap: not initially refed');
|
|
cp.unref();
|
|
strictEqual(cp._handle.hasRef(),
|
|
false, 'process_wrap: unref() ineffective');
|
|
cp.ref();
|
|
strictEqual(cp._handle.hasRef(),
|
|
true, 'process_wrap: ref() ineffective');
|
|
cp._handle.close(common.mustCall(() =>
|
|
strictEqual(cp._handle.hasRef(),
|
|
false, 'process_wrap: not unrefed on close')));
|
|
}
|
|
|
|
|
|
const dgram = require('dgram');
|
|
|
|
// dgram ipv4
|
|
{
|
|
const sock4 = dgram.createSocket('udp4');
|
|
strictEqual(Object.getPrototypeOf(sock4._handle).hasOwnProperty('hasRef'),
|
|
true, 'udp_wrap: ipv4: hasRef() missing');
|
|
strictEqual(sock4._handle.hasRef(),
|
|
true, 'udp_wrap: ipv4: not initially refed');
|
|
sock4.unref();
|
|
strictEqual(sock4._handle.hasRef(),
|
|
false, 'udp_wrap: ipv4: unref() ineffective');
|
|
sock4.ref();
|
|
strictEqual(sock4._handle.hasRef(),
|
|
true, 'udp_wrap: ipv4: ref() ineffective');
|
|
sock4._handle.close(common.mustCall(() =>
|
|
strictEqual(sock4._handle.hasRef(),
|
|
false, 'udp_wrap: ipv4: not unrefed on close')));
|
|
}
|
|
|
|
|
|
// dgram ipv6
|
|
{
|
|
const sock6 = dgram.createSocket('udp6');
|
|
strictEqual(Object.getPrototypeOf(sock6._handle).hasOwnProperty('hasRef'),
|
|
true, 'udp_wrap: ipv6: hasRef() missing');
|
|
strictEqual(sock6._handle.hasRef(),
|
|
true, 'udp_wrap: ipv6: not initially refed');
|
|
sock6.unref();
|
|
strictEqual(sock6._handle.hasRef(),
|
|
false, 'udp_wrap: ipv6: unref() ineffective');
|
|
sock6.ref();
|
|
strictEqual(sock6._handle.hasRef(),
|
|
true, 'udp_wrap: ipv6: ref() ineffective');
|
|
sock6._handle.close(common.mustCall(() =>
|
|
strictEqual(sock6._handle.hasRef(),
|
|
false, 'udp_wrap: ipv6: not unrefed on close')));
|
|
}
|
|
|
|
|
|
// pipe
|
|
{
|
|
const { Pipe, constants: PipeConstants } = process.binding('pipe_wrap');
|
|
const handle = new Pipe(PipeConstants.SOCKET);
|
|
strictEqual(Object.getPrototypeOf(handle).hasOwnProperty('hasRef'),
|
|
true, 'pipe_wrap: hasRef() missing');
|
|
strictEqual(handle.hasRef(),
|
|
true, 'pipe_wrap: not initially refed');
|
|
handle.unref();
|
|
strictEqual(handle.hasRef(),
|
|
false, 'pipe_wrap: unref() ineffective');
|
|
handle.ref();
|
|
strictEqual(handle.hasRef(),
|
|
true, 'pipe_wrap: ref() ineffective');
|
|
handle.close(common.mustCall(() =>
|
|
strictEqual(handle.hasRef(),
|
|
false, 'pipe_wrap: not unrefed on close')));
|
|
}
|
|
|
|
|
|
// tcp
|
|
{
|
|
const net = require('net');
|
|
const server = net.createServer(() => {}).listen(0);
|
|
strictEqual(Object.getPrototypeOf(server._handle).hasOwnProperty('hasRef'),
|
|
true, 'tcp_wrap: hasRef() missing');
|
|
strictEqual(server._handle.hasRef(),
|
|
true, 'tcp_wrap: not initially refed');
|
|
strictEqual(server._unref,
|
|
false, 'tcp_wrap: _unref initially incorrect');
|
|
server.unref();
|
|
strictEqual(server._handle.hasRef(),
|
|
false, 'tcp_wrap: unref() ineffective');
|
|
strictEqual(server._unref,
|
|
true, 'tcp_wrap: _unref not updated on unref()');
|
|
server.ref();
|
|
strictEqual(server._handle.hasRef(),
|
|
true, 'tcp_wrap: ref() ineffective');
|
|
strictEqual(server._unref,
|
|
false, 'tcp_wrap: _unref not updated on ref()');
|
|
server._handle.close(common.mustCall(() =>
|
|
strictEqual(server._handle.hasRef(),
|
|
false, 'tcp_wrap: not unrefed on close')));
|
|
}
|
|
|
|
|
|
// see also test/pseudo-tty/test-handle-wrap-isrefed-tty.js
|