mirror of
https://github.com/nodejs/node.git
synced 2025-05-06 01:43:00 +00:00
28e9a022df
Currently there are many instances where assert.fail is directly passed to a callback for error handling. Unfortunately this will swallow the error as it is the third argument of assert.fail that sets the message not the first. This commit adds a new function to test/common.js that simply wraps assert.fail and calls it with the provided message. Tip of the hat to @trott for pointing me in the direction of this. PR-URL: https://github.com/nodejs/node/pull/3453 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
33 lines
808 B
JavaScript
33 lines
808 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
|
|
if (!common.hasCrypto) {
|
|
console.log('1..0 # Skipped: missing crypto');
|
|
return;
|
|
}
|
|
|
|
const assert = require('assert');
|
|
const spawn = require('child_process').spawn;
|
|
const defaultCoreList = require('constants').defaultCoreCipherList;
|
|
|
|
function doCheck(arg, check) {
|
|
var out = '';
|
|
var arg = arg.concat([
|
|
'-pe',
|
|
'require("constants").defaultCipherList'
|
|
]);
|
|
spawn(process.execPath, arg, {}).
|
|
on('error', common.fail).
|
|
stdout.on('data', function(chunk) {
|
|
out += chunk;
|
|
}).on('end', function() {
|
|
assert.equal(out.trim(), check);
|
|
}).on('error', common.fail);
|
|
}
|
|
|
|
// test the default unmodified version
|
|
doCheck([], defaultCoreList);
|
|
|
|
// test the command line switch by itself
|
|
doCheck(['--tls-cipher-list=ABC'], 'ABC');
|