mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 12:03:30 +00:00
28e9a022df
Currently there are many instances where assert.fail is directly passed to a callback for error handling. Unfortunately this will swallow the error as it is the third argument of assert.fail that sets the message not the first. This commit adds a new function to test/common.js that simply wraps assert.fail and calls it with the provided message. Tip of the hat to @trott for pointing me in the direction of this. PR-URL: https://github.com/nodejs/node/pull/3453 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
21 lines
448 B
JavaScript
21 lines
448 B
JavaScript
'use strict';
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
var net = require('net');
|
|
|
|
var gotError = false;
|
|
|
|
process.on('exit', function() {
|
|
assert(gotError instanceof Error);
|
|
});
|
|
|
|
// this should fail with an async EINVAL error, not throw an exception
|
|
net.createServer(common.fail).listen({fd:0}).on('error', function(e) {
|
|
switch (e.code) {
|
|
case 'EINVAL':
|
|
case 'ENOTSOCK':
|
|
gotError = e;
|
|
break;
|
|
}
|
|
});
|