node/test-net-better-error-messages-path.js at 28e9a022df3ef89a0ea21e4ad86655eb408a8d96 - node - Gitea: Git with a cup of tea

jiangcuo/node

mirror of https://github.com/nodejs/node.git synced 2025-05-06 11:29:26 +00:00

Myles Borins 28e9a022df test: wrap assert.fail when passed to callback

Currently there are many instances where assert.fail is directly passed
to a callback for error handling. Unfortunately this will swallow the
error as it is the third argument of assert.fail that sets the message
not the first.

This commit adds a new function to test/common.js that simply wraps
assert.fail and calls it with the provided message.

Tip of the hat to @trott for pointing me in the direction of this.

PR-URL: https://github.com/nodejs/node/pull/3453
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

2015-10-24 14:42:41 -07:00

14 lines

330 B

JavaScript

Raw Blame History

 'use strict';
 var common = require('../common');
 var net = require('net');
 var assert = require('assert');
 var fp = '/tmp/fadagagsdfgsdf';
 var c = net.connect(fp);
 c.on('connect', common.fail);
 c.on('error', common.mustCall(function(e) {
   assert.equal(e.code, 'ENOENT');
   assert.equal(e.message, 'connect ENOENT ' + fp);
 }));