mirror of
https://github.com/nodejs/node.git
synced 2025-05-02 03:31:35 +00:00
28e9a022df
Currently there are many instances where assert.fail is directly passed to a callback for error handling. Unfortunately this will swallow the error as it is the third argument of assert.fail that sets the message not the first. This commit adds a new function to test/common.js that simply wraps assert.fail and calls it with the provided message. Tip of the hat to @trott for pointing me in the direction of this. PR-URL: https://github.com/nodejs/node/pull/3453 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
41 lines
1.4 KiB
JavaScript
41 lines
1.4 KiB
JavaScript
'use strict';
|
|
// Some operating systems report errors when an UDP message is sent to an
|
|
// unreachable host. This error can be reported by sendto() and even by
|
|
// recvfrom(). Node should not propagate this error to the user.
|
|
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
var dgram = require('dgram');
|
|
|
|
var socket = dgram.createSocket('udp4');
|
|
var buf = Buffer([1, 2, 3, 4]);
|
|
|
|
function ok() {}
|
|
socket.send(buf, 0, 0, common.PORT, '127.0.0.1', ok); // useful? no
|
|
socket.send(buf, 0, 4, common.PORT, '127.0.0.1', ok);
|
|
socket.send(buf, 1, 3, common.PORT, '127.0.0.1', ok);
|
|
socket.send(buf, 3, 1, common.PORT, '127.0.0.1', ok);
|
|
// Since length of zero means nothing, don't error despite OOB.
|
|
socket.send(buf, 4, 0, common.PORT, '127.0.0.1', ok);
|
|
|
|
assert.throws(function() {
|
|
socket.send(buf, 0, 5, common.PORT, '127.0.0.1', common.fail);
|
|
});
|
|
assert.throws(function() {
|
|
socket.send(buf, 2, 3, common.PORT, '127.0.0.1', common.fail);
|
|
});
|
|
assert.throws(function() {
|
|
socket.send(buf, 4, 4, common.PORT, '127.0.0.1', common.fail);
|
|
});
|
|
assert.throws(function() {
|
|
socket.send('abc', 4, 1, common.PORT, '127.0.0.1', common.fail);
|
|
});
|
|
assert.throws(function() {
|
|
socket.send('abc', 0, 4, common.PORT, '127.0.0.1', common.fail);
|
|
});
|
|
assert.throws(function() {
|
|
socket.send('abc', -1, 2, common.PORT, '127.0.0.1', common.fail);
|
|
});
|
|
|
|
socket.close(); // FIXME should not be necessary
|