mirror of
https://github.com/nodejs/node.git
synced 2025-05-06 07:40:16 +00:00

The name indicated only validation while it did much more and it returned a different value to the callee function. The underscore was also not necessary as the function is internal one way or the other. PR-URL: https://github.com/nodejs/node/pull/26809 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
50 lines
1.5 KiB
JavaScript
50 lines
1.5 KiB
JavaScript
'use strict';
|
|
// Flags: --expose_internals
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const getValidStdio = require('internal/child_process').getValidStdio;
|
|
|
|
const expectedError =
|
|
common.expectsError({ code: 'ERR_INVALID_OPT_VALUE', type: TypeError }, 2);
|
|
|
|
// Should throw if string and not ignore, pipe, or inherit
|
|
assert.throws(() => getValidStdio('foo'), expectedError);
|
|
|
|
// Should throw if not a string or array
|
|
assert.throws(() => getValidStdio(600), expectedError);
|
|
|
|
// Should populate stdio with undefined if len < 3
|
|
{
|
|
const stdio1 = [];
|
|
const result = getValidStdio(stdio1, false);
|
|
assert.strictEqual(stdio1.length, 3);
|
|
assert.strictEqual(result.hasOwnProperty('stdio'), true);
|
|
assert.strictEqual(result.hasOwnProperty('ipc'), true);
|
|
assert.strictEqual(result.hasOwnProperty('ipcFd'), true);
|
|
}
|
|
|
|
// Should throw if stdio has ipc and sync is true
|
|
const stdio2 = ['ipc', 'ipc', 'ipc'];
|
|
common.expectsError(() => getValidStdio(stdio2, true),
|
|
{ code: 'ERR_IPC_SYNC_FORK', type: Error }
|
|
);
|
|
|
|
|
|
if (common.isMainThread) {
|
|
const stdio3 = [process.stdin, process.stdout, process.stderr];
|
|
const result = getValidStdio(stdio3, false);
|
|
assert.deepStrictEqual(result, {
|
|
stdio: [
|
|
{ type: 'fd', fd: 0 },
|
|
{ type: 'fd', fd: 1 },
|
|
{ type: 'fd', fd: 2 }
|
|
],
|
|
ipc: undefined,
|
|
ipcFd: undefined
|
|
});
|
|
} else {
|
|
common.printSkipMessage(
|
|
'stdio is not associated with file descriptors in Workers');
|
|
}
|