mirror of
https://github.com/nodejs/node.git
synced 2025-04-29 06:19:07 +00:00
2243d79f74
646e5a4717changed the way that the domain hook callback is called. Previously, the callback was only used in the case that async_hooks were *not* being used (since domains already integrate with async hooks the way they should), and the corresponding deprecation warning also only emitted in that case. However, that commit didn’t move that condition along when the code was ported from C++ to JS. As a consequence, the domain hook callback was used when it wasn’t necessary to use it, and the deprecation warning emitted accidentally along with it. Refs:646e5a4717 (diff-9f21ce1b9d6d46fdd07b969e8a04e140L192)Refs:646e5a4717 (diff-e6db408e12db906ead6ddfac3de15a6fR119)Refs: https://github.com/nodejs/node/pull/33801#issuecomment-654744913 PR-URL: https://github.com/nodejs/node/pull/34245 Fixes: https://github.com/nodejs/node/issues/34069 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
63 lines
2.4 KiB
JavaScript
63 lines
2.4 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
'use strict';
|
|
// Simple tests of most basic domain functionality.
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const domain = require('domain');
|
|
|
|
process.on('warning', common.mustNotCall());
|
|
|
|
const d = new domain.Domain();
|
|
|
|
d.on('error', common.mustCall(function(er) {
|
|
console.error('caught', er);
|
|
|
|
assert.strictEqual(er.domain, d);
|
|
assert.strictEqual(er.domainThrown, true);
|
|
assert.ok(!er.domainEmitter);
|
|
assert.strictEqual(er.actual.code, 'ENOENT');
|
|
assert.ok(/\bthis file does not exist\b/i.test(er.actual.path));
|
|
assert.strictEqual(typeof er.actual.errno, 'number');
|
|
}));
|
|
|
|
|
|
// Implicit handling of thrown errors while in a domain, via the
|
|
// single entry points of ReqWrap and MakeCallback. Even if
|
|
// we try very hard to escape, there should be no way to, even if
|
|
// we go many levels deep through timeouts and multiple IO calls.
|
|
// Everything that happens between the domain.enter() and domain.exit()
|
|
// calls will be bound to the domain, even if multiple levels of
|
|
// handles are created.
|
|
d.run(function() {
|
|
setTimeout(function() {
|
|
const fs = require('fs');
|
|
fs.readdir(__dirname, function() {
|
|
fs.open('this file does not exist', 'r', function(er) {
|
|
assert.ifError(er);
|
|
throw new Error('should not get here!');
|
|
});
|
|
});
|
|
}, 100);
|
|
});
|